Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations for torch._C._distributed_c10d module. #46623

Closed
wants to merge 27 commits into from
Closed

Add type annotations for torch._C._distributed_c10d module. #46623

wants to merge 27 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Oct 20, 2020 •
edited

Stack from ghstack:

Differential Revision: D24761606

This was referenced Oct 20, 2020
Closed
Closed
@xuzhao9 xuzhao9 requested a review from malfet October 20, 2020 22:38
@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Oct 20, 2020
@dr-ci
Copy link

dr-ci bot commented Oct 20, 2020 •
edited

💊 CI failures summary and remediations

As of commit b6de0ab (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 121 times.

@xuzhao9 xuzhao9 requested a review from apaszke as a code owner October 21, 2020 17:06
@xuzhao9
Update on "Add type annotations for torch._C._distributed_c10d module."
5abe375 
[ghstack-poisoned]
@xuzhao9
Update on "Add type annotations for torch._C._distributed_c10d module."
8d15f8c 
[ghstack-poisoned]
@xuzhao9
Update on "Add type annotations for torch._C._distributed_c10d module."
fc1e352 
[ghstack-poisoned]
@xuzhao9
Update on "Add type annotations for torch._C._distributed_c10d module."
0388c2f 
[ghstack-poisoned]
@xuzhao9
Update on "Add type annotations for torch._C._distributed_c10d module."
f07c251 
[ghstack-poisoned]
@xuzhao9
Update on "Add type annotations for torch._C._distributed_c10d module."
215cfae 
[ghstack-poisoned]
@xuzhao9
Update on "Add type annotations for torch._C._distributed_c10d module."
4734fac 
[ghstack-poisoned]
@xuzhao9
Update on "Add type annotations for torch._C._distributed_c10d module."
d05a8e2 
[ghstack-poisoned]
@xuzhao9
Update on "Add type annotations for torch._C._distributed_c10d module."
c4e9398 
[ghstack-poisoned]
@xuzhao9
Update on "Add type annotations for torch._C._distributed_c10d module."
ae0e74c 
[ghstack-poisoned]
@xuzhao9
Update on "Add type annotations for torch._C._distributed_c10d module."
156c2c1 
[ghstack-poisoned]
walterddr
walterddr approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@walterddr walterddr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. please import to phab

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 73a3e70.

@xuzhao9 xuzhao9 deleted the gh/xuzhao9/2/head branch November 6, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@walterddr walterddr walterddr approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees
No one assigned
Labels
cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xuzhao9 @facebook-github-bot @malfet @walterddr