Add type annotations to torch._C._distributed_rpc module. #46624

xuzhao9 · 2020-10-20T22:37:47Z

Stack from ghstack:

Add type annotations to torch._C._distributed_rpc module. #46624 Add type annotations to torch._C._distributed_rpc module.
Add type annotations for torch._C._distributed_c10d module. #46623 Add type annotations for torch._C._distributed_c10d module.
Add Python declaration of torch._C and torch._C._autograd modules. #46622 Add Python declaration of torch._C and torch._C._autograd modules.

Differential Revision: D24761656

[ghstack-poisoned]

dr-ci · 2020-10-20T23:00:01Z

💊 CI failures summary and remediations

As of commit 980619c (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 145 times.

[ghstack-poisoned]

ghstack-source-id: 990d10a2ae28ffccde4256f6ae207d9d494f3e34 Pull Request resolved: #46624

[ghstack-poisoned]

malfet

Looks good to me, but can you please modify mypy.ini to add torch.distributed.rpc to the set of modules where type annotation is enforced.

[ghstack-poisoned]

xuzhao9 · 2020-11-04T21:30:37Z

torch/distributed/rpc/internal.py

@@ -224,8 +227,8 @@ def _start_record_function(exec_type, func_name, current_worker_name, dest_worke
    profile_key = "rpc_{}#{}({} -> {})".format(
        exec_type.value, str(func_name), current_worker_name, dest_worker_name
    )
-    rf = torch.autograd._RecordFunction()
-    torch.autograd._run_before_callbacks(rf, profile_key)
+    rf = torch.autograd._RecordFunction()  # type: ignore[attr-defined]


Ignoring this error because I don't find anywhere "_RecordFunction()" and "_run_before_callbacks()" are defined.

xuzhao9 · 2020-11-04T21:32:12Z

torch/distributed/rpc/api.py

        pass
 except TypeError as exc:
    # TypeError: metaclass conflict: the metaclass of a derived class
    # must be a (non-strict) subclass of the metaclasses of all its bases
-    class RRefMeta(PyRRef.__class__, GenericWithOneTypeVar.__class__):
+    # Mypy doesn't understand __class__ (mypy bug #4177)
+    class RRefMeta(PyRRef.__class__, GenericWithOneTypeVar.__class__):  # type: ignore


Ignore all type errors because this line (and line 393) will cause multiple type errors.

[ghstack-poisoned]

ghstack-source-id: 653f2dc89bb18de3a01ec64f1b5a18eef9151148 Pull Request resolved: #46624

xuzhao9 · 2020-11-04T22:20:18Z

torch/distributed/rpc/api.py

@@ -379,16 +379,18 @@ def _rref_typeof_on_user(rref):

 try:
    # Combine the implementation class and the type class.
-    class RRef(PyRRef, GenericWithOneTypeVar):
+    class RRef(PyRRef, Generic[T]):


mypy complains " Variable "torch.distributed.rpc.api.GenericWithOneTypeVar" is not valid as a type [valid-type]" if use GenericWithOneTypeVar here.

[ghstack-poisoned]

xuzhao9 · 2020-11-04T23:50:17Z

torch/csrc/distributed/rpc/init.cpp

@@ -114,6 +120,20 @@ PyObject* rpc_init(PyObject* _unused, PyObject* noargs) {
              "join", &RpcAgent::join, py::call_guard<py::gil_scoped_release>())
          .def(
              "sync", &RpcAgent::sync, py::call_guard<py::gil_scoped_release>())
+          .def(


Adding three definitions because they are used in internal.py and api.py.

xuzhao9 · 2020-11-05T00:57:05Z

Looks good to me, but can you please modify mypy.ini to add torch.distributed.rpc to the set of modules where type annotation is enforced.

Thanks for the review. I have modified mypy.ini to enable the type checking related to this stack of changes. Note I have to introduce some changes to eliminate the errors. Please see my follow-up comments and let me know if you have any feedbacks.

[ghstack-poisoned]

ghstack-source-id: 5243889c76c5cde8c2c221697080be23d7605446 Pull Request resolved: #46624

[ghstack-poisoned]

ghstack-source-id: cd8c93b49d1c02174f3bc31f3ef6f2a07308a0fa Pull Request resolved: #46624

Differential Revision: [D24761656](https://our.internmc.facebook.com/intern/diff/D24761656) [ghstack-poisoned]

ghstack-source-id: 2c9ba154b8c7e2c15a3cd47420f4d3a7e884afe9 Pull Request resolved: #46624

facebook-github-bot · 2020-11-06T13:13:39Z

@xuzhao9 merged this pull request in eaa993a.

Add type annotations to torch._C._distributed_rpc module.

f7cba26

[ghstack-poisoned]

xuzhao9 requested review from mingzhe09088, mrshenli, pietern, pritamdamania87, rohan-varma and zhaojuanmao as code owners October 20, 2020 22:37

This was referenced Oct 20, 2020

Add Python declaration of torch._C and torch._C._autograd modules. #46622

Closed

Add type annotations for torch._C._distributed_c10d module. #46623

Closed

facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Oct 20, 2020

xuzhao9 requested review from malfet and walterddr and removed request for pietern, rohan-varma, pritamdamania87, mrshenli, mingzhe09088 and zhaojuanmao October 20, 2020 22:39

Update on "Add type annotations to torch._C._distributed_rpc module."

cd0ef39

[ghstack-poisoned]

xuzhao9 requested a review from apaszke as a code owner October 21, 2020 00:07

Update on "Add type annotations to torch._C._distributed_rpc module."

c777af2

[ghstack-poisoned]

Update on "Add type annotations to torch._C._distributed_rpc module."

24b0a38

[ghstack-poisoned]

xuzhao9 added a commit that referenced this pull request Oct 21, 2020

Add type annotations to torch._C._distributed_rpc module.

404d73c

ghstack-source-id: 990d10a2ae28ffccde4256f6ae207d9d494f3e34 Pull Request resolved: #46624

Update on "Add type annotations to torch._C._distributed_rpc module."

42d7019

[ghstack-poisoned]

Update on "Add type annotations to torch._C._distributed_rpc module."

8e132dc

[ghstack-poisoned]

xuzhao9 requested a review from walterddr October 27, 2020 18:16

facebook-github-bot added the cla signed label Oct 30, 2020

malfet approved these changes Nov 3, 2020

View reviewed changes

Update on "Add type annotations to torch._C._distributed_rpc module."

bfb5791

[ghstack-poisoned]

xuzhao9 commented Nov 4, 2020

View reviewed changes

Update on "Add type annotations to torch._C._distributed_rpc module."

2da1e9a

[ghstack-poisoned]

Update on "Add type annotations to torch._C._distributed_rpc module."

5f486c8

[ghstack-poisoned]

xuzhao9 added a commit that referenced this pull request Nov 4, 2020

Add type annotations to torch._C._distributed_rpc module.

56a3f89

ghstack-source-id: 653f2dc89bb18de3a01ec64f1b5a18eef9151148 Pull Request resolved: #46624

xuzhao9 commented Nov 4, 2020

View reviewed changes

Update on "Add type annotations to torch._C._distributed_rpc module."

489dbe3

[ghstack-poisoned]

xuzhao9 commented Nov 4, 2020

View reviewed changes

Update on "Add type annotations to torch._C._distributed_rpc module."

6ec3e6a

[ghstack-poisoned]

xuzhao9 added a commit that referenced this pull request Nov 5, 2020

Add type annotations to torch._C._distributed_rpc module.

c74c9c6

ghstack-source-id: 5243889c76c5cde8c2c221697080be23d7605446 Pull Request resolved: #46624

walterddr approved these changes Nov 5, 2020

View reviewed changes

Update on "Add type annotations to torch._C._distributed_rpc module."

fe5e780

[ghstack-poisoned]

xuzhao9 added a commit that referenced this pull request Nov 5, 2020

Add type annotations to torch._C._distributed_rpc module.

841f462

ghstack-source-id: cd8c93b49d1c02174f3bc31f3ef6f2a07308a0fa Pull Request resolved: #46624

Update on "Add type annotations to torch._C._distributed_rpc module."

08e109e

Differential Revision: [D24761656](https://our.internmc.facebook.com/intern/diff/D24761656) [ghstack-poisoned]

Update on "Add type annotations to torch._C._distributed_rpc module."

980619c

Differential Revision: [D24761656](https://our.internmc.facebook.com/intern/diff/D24761656) [ghstack-poisoned]

xuzhao9 added a commit that referenced this pull request Nov 6, 2020

Add type annotations to torch._C._distributed_rpc module.

26c30f9

ghstack-source-id: 2c9ba154b8c7e2c15a3cd47420f4d3a7e884afe9 Pull Request resolved: #46624

facebook-github-bot closed this in eaa993a Nov 6, 2020

facebook-github-bot added the Merged label Nov 6, 2020

xuzhao9 deleted the gh/xuzhao9/3/head branch November 6, 2020 15:13

pritamdamania87 mentioned this pull request Dec 3, 2020

[master] new default signature: op=<ReduceOp.SUM: 0>from `op=<ReduceOp.SUM> #48466

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add type annotations to torch._C._distributed_rpc module. #46624

Add type annotations to torch._C._distributed_rpc module. #46624

xuzhao9 commented Oct 20, 2020 •

edited

dr-ci bot commented Oct 20, 2020 •

edited

malfet left a comment

xuzhao9 Nov 4, 2020

xuzhao9 Nov 4, 2020

xuzhao9 Nov 4, 2020

xuzhao9 Nov 4, 2020

xuzhao9 commented Nov 5, 2020

facebook-github-bot commented Nov 6, 2020

Add type annotations to torch._C._distributed_rpc module. #46624

Add type annotations to torch._C._distributed_rpc module. #46624

Conversation

xuzhao9 commented Oct 20, 2020 • edited

dr-ci bot commented Oct 20, 2020 • edited

💊 CI failures summary and remediations

malfet left a comment

Choose a reason for hiding this comment

xuzhao9 Nov 4, 2020

Choose a reason for hiding this comment

xuzhao9 Nov 4, 2020

Choose a reason for hiding this comment

xuzhao9 Nov 4, 2020

Choose a reason for hiding this comment

xuzhao9 Nov 4, 2020

Choose a reason for hiding this comment

xuzhao9 commented Nov 5, 2020

facebook-github-bot commented Nov 6, 2020

xuzhao9 commented Oct 20, 2020 •

edited

dr-ci bot commented Oct 20, 2020 •

edited