New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including generator param in randperm documentation #47231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the follow up. :-) - we definitely need better linter @samestep
@mruberry I couldn't seem to find where there's duplication. I think the double search result is because it is in both Python docs and mentioned in C++ docs, but my understanding of the documentation is not very deep. |
💊 CI failures summary and remediationsAs of commit 3b0bf43 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 1 failure confirmed as flaky and can be ignored:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 13 times. |
Thanks @janeyx99! |
5306b4b
to
683772a
Compare
683772a
to
266b112
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janeyx99 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #47231 +/- ##
=======================================
Coverage 60.81% 60.81%
=======================================
Files 2748 2748
Lines 254047 254047
=======================================
+ Hits 154503 154505 +2
+ Misses 99544 99542 -2 |
The
randperm
documentation is outdated and did not use to include the optionalgenerator
parameter. This PR just adds that along with thepin_memory
parameter.This PR was brought up in PR 47022, but is now rebased onto master.
New docs look like: