[ONNX] Use parameter values in onnx shape inference #47486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowenBao
force-pushed
the
onnx_initializer_shape_inference
branch
from
89f2a69
to
eac0766
Compare
facebook-github-bot
added
cla signed
oncall: jit
💊 CI failures summary and remediationsAs of commit 50ee284 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 16 times. |
heitorschueroff
added
triaged
BowenBao
force-pushed
the
onnx_initializer_shape_inference
branch
2 times, most recently
from
cf96c70
to
7f007fa
Compare
BowenBao
force-pushed
the
onnx_initializer_shape_inference
branch
from
7f007fa
to
50ee284
Compare
Codecov Report
@@ Coverage Diff @@
## master #47486 +/- ##
===========================================
+ Coverage 42.03% 81.33% +39.29%
===========================================
Files 472 1839 +1367
Lines 64834 198587 +133753
===========================================
+ Hits 27256 161523 +134267
+ Misses 37578 37064 -514 |
|
closing, merged with #48071 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #46629
Adds an additional run of onnx shape inference after constant folding, since initializer may have changed and affected shape inference.