quant: add type annotations on quantization.fx.Quantizer matches #48350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As titled, continuing to incrementally type quantization.fx.Quantizer. Test Plan: ``` mypy torch/quantization/ python test/test_quantization.py TestQuantizeFx ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Nov 21, 2020
…atches" Summary: As titled, continuing to incrementally type quantization.fx.Quantizer. Test Plan: ``` mypy torch/quantization/ python test/test_quantization.py TestQuantizeFx ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25138947](https://our.internmc.facebook.com/intern/diff/D25138947) [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Nov 21, 2020
Summary: As titled, continuing to incrementally type quantization.fx.Quantizer. Test Plan: ``` mypy torch/quantization/ python test/test_quantization.py TestQuantizeFx ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: cbfb1e7ca0a719af41a1ffc211e4290fb3e1e11b Pull Request resolved: #48350
💊 CI failures summary and remediationsAs of commit 0f79834 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
ci.pytorch.org: 2 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 8 times. |
…atches" Summary: As titled, continuing to incrementally type quantization.fx.Quantizer. Test Plan: ``` mypy torch/quantization/ python test/test_quantization.py TestQuantizeFx ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25138947](https://our.internmc.facebook.com/intern/diff/D25138947) [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Nov 21, 2020
Summary: As titled, continuing to incrementally type quantization.fx.Quantizer. Test Plan: ``` mypy torch/quantization/ python test/test_quantization.py TestQuantizeFx ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 020fe46b33bb9c54e9c0f9bbd20d1972f9dbb8e8 Pull Request resolved: #48350
This was referenced Nov 21, 2020
Closed
jerryzh168
approved these changes
Nov 21, 2020
…r matches" Summary: As titled, continuing to incrementally type quantization.fx.Quantizer. Test Plan: ``` mypy torch/quantization/ python test/test_quantization.py TestQuantizeFx ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25138947](https://our.internmc.facebook.com/intern/diff/D25138947) [ghstack-poisoned]
|
This pull request has been merged in 8581c02. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
As titled, continuing to incrementally type quantization.fx.Quantizer.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25138947