-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quant fx: fix typo #48356
Closed
Closed
quant fx: fix typo #48356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As titled Test Plan: CI Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Nov 21, 2020
vkuzo
added a commit
that referenced
this pull request
Nov 21, 2020
Summary: As titled Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: a938fce5187eb7e2645b01ccbbb1e9d2826b4e53 Pull Request resolved: #48356
jerryzh168
approved these changes
Nov 21, 2020
💊 CI failures summary and remediationsAs of commit 5cd34ed (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
ci.pytorch.org: 2 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 5 times. |
Summary: As titled Test Plan: CI Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25140834](https://our.internmc.facebook.com/intern/diff/D25140834) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/vkuzo/171/base #48356 +/- ##
======================================================
+ Coverage 63.77% 80.86% +17.08%
======================================================
Files 1692 1854 +162
Lines 168496 199922 +31426
======================================================
+ Hits 107461 161660 +54199
+ Misses 61035 38262 -22773 |
This pull request has been merged in 1d98441. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
As titled
Test Plan:
CI
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25140834