Migrate some torch.fft tests to use OpInfos #48428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Nov 24, 2020
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit dbb909a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 82 times. |
[ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Nov 24, 2020
ghstack-source-id: 21d8415bf219382a5100b5a4907ad1409e0ded2c Pull Request resolved: #48428
[ghstack-poisoned]
[ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Nov 26, 2020
ghstack-source-id: 11a427ea77e5fb307fd2f6dcfc7b82051accbcef Pull Request resolved: #48428
[ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Nov 26, 2020
ghstack-source-id: 054cd4d89887575c79800f4839e9a6f41c7bf500 Pull Request resolved: #48428
[ghstack-poisoned]
[ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Nov 27, 2020
ghstack-source-id: 3b9f7dd58817e35c52945fb3fdf14c8ceb7eb4a3 Pull Request resolved: #48428
[ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Nov 28, 2020
ghstack-source-id: 3543e29ebb4d41067b9dd371e62e8aaa76382156 Pull Request resolved: #48428
|
Hey @peterbell10! This is really cool. I have a question about how we want to test backward, however, that I'd like to hear your thoughts on. Ideally autograd (and soon the jit) will only need testing in test_ops.py. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Dec 8, 2020
ghstack-source-id: 172f598a12945ff76ec891541fa2c0433dad6a56 Pull Request resolved: pytorch#48428
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D25868666