Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unnecessary SpectralFuncInfo logic #48712

Closed
wants to merge 15 commits into from

Conversation

peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Dec 2, 2020

Stack from ghstack:

Differential Revision: D25868675

peterbell10 added a commit that referenced this pull request Dec 2, 2020
ghstack-source-id: cc7304dcf29e006ef0c2544fbf558fd962581827
Pull Request resolved: #48712
@dr-ci
Copy link

dr-ci bot commented Dec 2, 2020

💊 CI failures summary and remediations

As of commit bb2f4c7 (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_bionic_py3_8_gcc9_coverage_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun) ❄️

error pulling image configuration: Get https://prod-us-east-1-starport-layer-bucket.s3.us-east-1.amazonaws.com/f3a05d-308535385114-d6b91948-a459-1541-cbc6-561aab5de0ac/fdda5322-377d-4dbb-886d-6e133d1c6a00?X-Amz-Security-Token=IQoJb3JpZ2luX2VjEIH%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCIQDUWi9FunoXOFfX%2B88LIzpNbIks5pq7vEw6YcjLcoAYDwIgS%2Fj947BiDF64Or75QmU31ee1tSp7WYha3YyvyimJDgQq7wIIShACGgw1OTExMDU5MTQ5NTIiDHuqASmQll1qvyy9XyrMAlu5gn%2F9vzgH%2BCYs72g4ud0s%2FRro92PZ9FCVGe%2B%2FF0L6cKSJfd48UavEp2gZncLxdM1lE3UYTdEANzqYV6XzoP1Y%2BUwwwSLyT3%2Bnh9vAgCGak%2FHtCekK5K1FIspCE%2FJMywtM92XsHcDa5ATLKOkx2Gogf7qcbtpf8lgZTsYIranZAHbmaYqceMHnDn%2FrHJuUlNrxdh%2BVj7E4tPalWjAXDYPIsv5i17rjpJgxNPf8s9%2Fq%2FYB1rhSXzCproD3STsuGcMwyyUo0H9IA4stdeYDiD1uPACjaODm9XFXp08awbxCgK7aUs8jylMOYN0RAMkx3XrJVKkzN2903CbugQz5jzJV%2FiIRyszLlO3W8AU1lBRm2oQOIaPU8KXpqv1WiqvAY8WOcagXNag55wOLvGkXLKV8U4ho%2FV7HNOunSkqn%2BDnRTqLID7mtWOQ1o8tJhMJzu3P8FOucBbHuWSbZe31kkn%2FJQeTatAkFI7GZDg9KvntxLt78xElslP9mVs1caH4QJaC2gMhWeZaRq2GPDTprDTS0MHMRQgn%2FY0X8JtJA2fYedbTQnbAJelKWs8yiah3lycBhdQeG7Cf3qIQd8CmvT3WFo0R37FjopZB0q988YLEaW%2BvdtgUd0XBE6UfRko5FpN5oIsSXVA2k0MbnQjsGSW6Hg9rDYUnpkuMqVms0%2FI8A4CQ1HBtYdFRPEKdh2bQ0KSlrwTo7qb7Ki4YF%2FQxg97jmEGV3w8KW93HinnlSj%2FBmLRDUpsLub%2Bs4EijGC&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20210107T172804Z&X-Amz-SignedHeaders=host&X-Amz-Expires=3600&X-Amz-Credential=ASIAYTIFIPBEPX3J6J4K%2F20210107%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Signature=e0602a353f4959f3da68ee9cef567da49ce42d161ed971cf38847342251dfa32: dial tcp 52.217.14.16:443: i/o timeout
Parallel backend flags: 
DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-bionic-py3.8-gcc9:ef3e94d1a5a6bd914698192714f244e13bdf086f
error pulling image configuration: Get https://prod-us-east-1-starport-layer-bucket.s3.us-east-1.amazonaws.com/f3a05d-308535385114-d6b91948-a459-1541-cbc6-561aab5de0ac/fdda5322-377d-4dbb-886d-6e133d1c6a00?X-Amz-Security-Token=IQoJb3JpZ2luX2VjEIH%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCIQDUWi9FunoXOFfX%2B88LIzpNbIks5pq7vEw6YcjLcoAYDwIgS%2Fj947BiDF64Or75QmU31ee1tSp7WYha3YyvyimJDgQq7wIIShACGgw1OTExMDU5MTQ5NTIiDHuqASmQll1qvyy9XyrMAlu5gn%2F9vzgH%2BCYs72g4ud0s%2FRro92PZ9FCVGe%2B%2FF0L6cKSJfd48UavEp2gZncLxdM1lE3UYTdEANzqYV6XzoP1Y%2BUwwwSLyT3%2Bnh9vAgCGak%2FHtCekK5K1FIspCE%2FJMywtM92XsHcDa5ATLKOkx2Gogf7qcbtpf8lgZTsYIranZAHbmaYqceMHnDn%2FrHJuUlNrxdh%2BVj7E4tPalWjAXDYPIsv5i17rjpJgxNPf8s9%2Fq%2FYB1rhSXzCproD3STsuGcMwyyUo0H9IA4stdeYDiD1uPACjaODm9XFXp08awbxCgK7aUs8jylMOYN0RAMkx3XrJVKkzN2903CbugQz5jzJV%2FiIRyszLlO3W8AU1lBRm2oQOIaPU8KXpqv1WiqvAY8WOcagXNag55wOLvGkXLKV8U4ho%2FV7HNOunSkqn%2BDnRTqLID7mtWOQ1o8tJhMJzu3P8FOucBbHuWSbZe31kkn%2FJQeTatAkFI7GZDg9KvntxLt78xElslP9mVs1caH4QJaC2gMhWeZaRq2GPDTprDTS0MHMRQgn%2FY0X8JtJA2fYedbTQnbAJelKWs8yiah3lycBhdQeG7Cf3qIQd8CmvT3WFo0R37FjopZB0q988YLEaW%2BvdtgUd0XBE6UfRko5FpN5oIsSXVA2k0MbnQjsGSW6Hg9rDYUnpkuMqVms0%2FI8A4CQ1HBtYdFRPEKdh2bQ0KSlrwTo7qb7Ki4YF%2FQxg97jmEGV3w8KW93HinnlSj%2FBmLRDUpsLub%2Bs4EijGC&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20210107T172804Z&X-Amz-SignedHeaders=host&X-Amz-Expires=3600&X-Amz-Credential=ASIAYTIFIPBEPX3J6J4K%2F20210107%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Signature=e0602a353f4959f3da68ee9cef567da49ce42d161ed971cf38847342251dfa32: dial tcp 52.217.14.16:443: i/o timeout


Exited with code exit status 1

---
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 43 times.

peterbell10 added a commit that referenced this pull request Dec 4, 2020
ghstack-source-id: 4953d5d32db6e9bb5b26dac0e78f01f1b8b5659f
Pull Request resolved: #48712
peterbell10 added a commit that referenced this pull request Dec 5, 2020
ghstack-source-id: 5fc91f2b845da3dc812a020144c8d2be0474e411
Pull Request resolved: #48712
peterbell10 added a commit that referenced this pull request Dec 6, 2020
ghstack-source-id: f1408905653e87364f024ececab3d8a8ca5d708b
Pull Request resolved: #48712
peterbell10 added a commit that referenced this pull request Dec 7, 2020
ghstack-source-id: 28931b5137391cf8c132b272cf985434c2086e82
Pull Request resolved: #48712
peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Dec 8, 2020
ghstack-source-id: 28931b5137391cf8c132b272cf985434c2086e82
Pull Request resolved: pytorch#48712
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in d25c673.

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/31/head branch January 15, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants