[reland][quant][fix] Add bias once in conv_fused (#48593) #48661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias in ConvBn module fixes: #48514 Test Plan: Imported from OSS Reviewed By: raghuramank100 [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Dec 1, 2020
Summary: Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias in ConvBn module fixes: #48514 Test Plan: Imported from OSS Reviewed By: raghuramank100 ghstack-source-id: 9650155f9df06d0bbf44888ebc637eb998af4e8a Pull Request resolved: #48661
💊 CI failures summary and remediationsAs of commit c7b7a84 (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_test is failing. Please create an issue with title prefixed by 🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 20 times. |
Summary: Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias in ConvBn module fixes: #48514 Test Plan: Imported from OSS Reviewed By: raghuramank100 Differential Revision: [D25249175](https://our.internmc.facebook.com/intern/diff/D25249175) [ghstack-poisoned]
vkuzo
approved these changes
Dec 2, 2020
Comment on lines
97
to
100
| if self.bias: | ||
| zero_bias = torch.zeros_like(self.bias) | ||
| else: | ||
| zero_bias = torch.zeros(self.out_channels, device=scaled_weight.device()) |
There was a problem hiding this comment.
nice catch. Can we add a comment here with the motivation, similar to this PR summary?
Summary: Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias in ConvBn module fixes: #48514 Test Plan: Imported from OSS Reviewed By: raghuramank100 Differential Revision: [D25249175](https://our.internmc.facebook.com/intern/diff/D25249175) [ghstack-poisoned]
Summary: Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias in ConvBn module fixes: #48514 Test Plan: Imported from OSS Reviewed By: raghuramank100 Differential Revision: [D25249175](https://our.internmc.facebook.com/intern/diff/D25249175) [ghstack-poisoned]
Summary: Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias in ConvBn module fixes: #48514 Test Plan: Imported from OSS Reviewed By: raghuramank100 Differential Revision: [D25249175](https://our.internmc.facebook.com/intern/diff/D25249175) [ghstack-poisoned]
malfet
approved these changes
Dec 2, 2020
jerryzh168
added a commit
that referenced
this pull request
Dec 2, 2020
Summary: Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias in ConvBn module fixes: #48514 Test Plan: Imported from OSS Reviewed By: raghuramank100 ghstack-source-id: bd0dce0962b57e78a4cac405658f644da384a25f Pull Request resolved: #48661
|
This pull request has been merged in 52f0af0. |
shaibagon
pushed a commit
to shaibagon/pytorch
that referenced
this pull request
Dec 3, 2020
…orch#48661) Summary: Pull Request resolved: pytorch#48661 Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias in ConvBn module fixes: pytorch#48514 Test Plan: Imported from OSS Imported from OSS Reviewed By: vkuzo Differential Revision: D25249175 fbshipit-source-id: 4536c7545d3dcd7e8ea254368ffb7cf15118d78c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module
this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias
in ConvBn module
fixes: #48514
Test Plan: Imported from OSS
Reviewed By: raghuramank100
Differential Revision: D25249175