Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reland][quant][fix] Add bias once in conv_fused (#48593) #48661

Closed
wants to merge 5 commits into from
Closed

[reland][quant][fix] Add bias once in conv_fused (#48593) #48661

wants to merge 5 commits into from

Commits on Dec 1, 2020

  1. [reland][quant][fix] Add bias once in conv_fused (#48593) 

    Summary:
Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module
this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias
in ConvBn module

fixes: #48514

Test Plan: Imported from OSS

Reviewed By: raghuramank100

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    6731ea7 View commit details
    Browse the repository at this point in the history

  2. Update on "[reland][quant][fix] Add bias once in conv_fused (#48593)" 

    Summary:
Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module
this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias
in ConvBn module

fixes: #48514

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D25249175](https://our.internmc.facebook.com/intern/diff/D25249175)

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    118c96f View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Update on "[reland][quant][fix] Add bias once in conv_fused (#48593)" 

    Summary:
Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module
this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias
in ConvBn module

fixes: #48514

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D25249175](https://our.internmc.facebook.com/intern/diff/D25249175)

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    a97f4ca View commit details
    Browse the repository at this point in the history

  2. Update on "[reland][quant][fix] Add bias once in conv_fused (#48593)" 

    Summary:
Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module
this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias
in ConvBn module

fixes: #48514

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D25249175](https://our.internmc.facebook.com/intern/diff/D25249175)

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    24bf342 View commit details
    Browse the repository at this point in the history

  3. Update on "[reland][quant][fix] Add bias once in conv_fused (#48593)" 

    Summary:
Previously _conv_forward will add self.bias to the result, so bias is added twice in qat ConvBn module
this PR added a bias argument to _conv_forward and _conv_forward is called with zero bias
in ConvBn module

fixes: #48514

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D25249175](https://our.internmc.facebook.com/intern/diff/D25249175)

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    c7b7a84 View commit details
    Browse the repository at this point in the history