fx quant: add types to quantization_patterns #48851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adding typing to improve readability. Note: this uncovered a few missing return statements, we should fix that before landing. Test Plan: ``` mypy torch/quantization/ ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Dec 4, 2020
Summary: Adding typing to improve readability. Note: this uncovered a few missing return statements, we should fix that before landing. Test Plan: ``` mypy torch/quantization/ ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f8ca4e13f7e2fa0d77281361f011b5fed81808e4 Pull Request resolved: #48851
Summary: Adding typing to improve readability. Note: this uncovered a few missing return statements, we should fix that before landing. Test Plan: ``` mypy torch/quantization/ ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25338644](https://our.internmc.facebook.com/intern/diff/D25338644) [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Dec 4, 2020
Summary: Adding typing to improve readability. Note: this uncovered a few missing return statements, we should fix that before landing. Test Plan: ``` mypy torch/quantization/ ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 14ef25dab7ebba59eb583988e8fc6290bf215e5a Pull Request resolved: #48851
jerryzh168
approved these changes
Dec 5, 2020
Summary: Adding typing to improve readability. Note: this uncovered a few missing return statements, we should fix that before landing. Test Plan: ``` mypy torch/quantization/ ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25338644](https://our.internmc.facebook.com/intern/diff/D25338644) [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Dec 5, 2020
Summary: Adding typing to improve readability. Note: this uncovered a few missing return statements, we should fix that before landing. Test Plan: ``` mypy torch/quantization/ ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 890625f5c846e7c21eae8ca936c70652e59d6fbd Pull Request resolved: #48851
💊 CI failures summary and remediationsAs of commit f8ad628 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
|
This pull request has been merged in 0923d19. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Adding typing to improve readability.
Note: this uncovered a few missing return statements, we should
fix that before landing.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25338644