Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fx quant: add types to quantization_patterns #48851

Closed
wants to merge 3 commits into from
Closed

fx quant: add types to quantization_patterns #48851

wants to merge 3 commits into from

Commits on Dec 4, 2020

  1. fx quant: add types to quantization_patterns 

    Summary:

Adding typing to improve readability.

Note: this uncovered a few missing return statements, we should
fix that before landing.

Test Plan:

```
mypy torch/quantization/
```

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @vkuzo
    vkuzo committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    0d42399 View commit details
    Browse the repository at this point in the history

  2. fix nit on "fx quant: add types to quantization_patterns" 

    Summary:

Adding typing to improve readability.

Note: this uncovered a few missing return statements, we should
fix that before landing.

Test Plan:

```
mypy torch/quantization/
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25338644](https://our.internmc.facebook.com/intern/diff/D25338644)

[ghstack-poisoned]
    @vkuzo
    vkuzo committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    b2acdf9 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2020

  1. Update on "fx quant: add types to quantization_patterns" 

    Summary:

Adding typing to improve readability.

Note: this uncovered a few missing return statements, we should
fix that before landing.

Test Plan:

```
mypy torch/quantization/
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25338644](https://our.internmc.facebook.com/intern/diff/D25338644)

[ghstack-poisoned]
    @vkuzo
    vkuzo committed Dec 5, 2020
    Configuration menu
    Copy the full SHA
    f8ad628 View commit details
    Browse the repository at this point in the history