Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch] Avoid move-constructing a List in listConstruct #49355

Closed
wants to merge 3 commits into from
Closed

[PyTorch] Avoid move-constructing a List in listConstruct #49355

wants to merge 3 commits into from

Commits on Dec 14, 2020

  1. [PyTorch] Avoid move-constructing a List in listConstruct 

    List's move ctor is a little bit more expensive than you might expect, but we can easily avoid it.

Differential Revision: [D25542190](https://our.internmc.facebook.com/intern/diff/D25542190/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25542190/)!

[ghstack-poisoned]
    @swolchok
    swolchok committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    368a6cd View commit details
    Browse the repository at this point in the history

  2. format on "[PyTorch] Avoid move-constructing a List in listConstruct" 

    List's move ctor is a little bit more expensive than you might expect, but we can easily avoid it.

Differential Revision: [D25542190](https://our.internmc.facebook.com/intern/diff/D25542190/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25542190/)!

[ghstack-poisoned]
    @swolchok
    swolchok committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    454082a View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Update on "[PyTorch] Avoid move-constructing a List in listConstruct" 

    List's move ctor is a little bit more expensive than you might expect, but we can easily avoid it.

Differential Revision: [D25542190](https://our.internmc.facebook.com/intern/diff/D25542190/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25542190/)!

[ghstack-poisoned]
    @swolchok
    swolchok committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    03d4bda View commit details
    Browse the repository at this point in the history