[PyTorch] Avoid move-constructing a List in listConstruct #49355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List's move ctor is a little bit more expensive than you might expect, but we can easily avoid it. Differential Revision: [D25542190](https://our.internmc.facebook.com/intern/diff/D25542190/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25542190/)! [ghstack-poisoned]
facebook-github-bot
added
cla signed
oncall: jit
swolchok
added a commit
that referenced
this pull request
Dec 14, 2020
List's move ctor is a little bit more expensive than you might expect, but we can easily avoid it. Differential Revision: [D25542190](https://our.internmc.facebook.com/intern/diff/D25542190/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25542190/)! ghstack-source-id: 118549513 Pull Request resolved: #49355
💊 CI failures summary and remediationsAs of commit 03d4bda (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 23 times. |
List's move ctor is a little bit more expensive than you might expect, but we can easily avoid it. Differential Revision: [D25542190](https://our.internmc.facebook.com/intern/diff/D25542190/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25542190/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 14, 2020
Pull Request resolved: #49355 List's move ctor is a little bit more expensive than you might expect, but we can easily avoid it. ghstack-source-id: 118553015 Differential Revision: [D25542190](https://our.internmc.facebook.com/intern/diff/D25542190/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25542190/)!
This was referenced Dec 14, 2020
swolchok
requested review from
hlu1,
ZolotukhinM,
ajyu,
bwasti and
dzhulgakov
List's move ctor is a little bit more expensive than you might expect, but we can easily avoid it. Differential Revision: [D25542190](https://our.internmc.facebook.com/intern/diff/D25542190/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25542190/)! [ghstack-poisoned]
|
This pull request has been merged in 76d09ec. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
) Summary: Pull Request resolved: pytorch#49355 List's move ctor is a little bit more expensive than you might expect, but we can easily avoid it. ghstack-source-id: 118624596 Test Plan: Roughly 1% improvement on internal benchmark. Reviewed By: hlu1 Differential Revision: D25542190 fbshipit-source-id: 08532642c7d1f1604e16c8ebefd1ed3e56f7c919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
List's move ctor is a little bit more expensive than you might expect, but we can easily avoid it.
Differential Revision: D25542190
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!