Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gradient Compression] Change wait() to value() in some callbacks of PowerSGD communication hook #49709

Closed
wants to merge 4 commits into from
Closed

[Gradient Compression] Change wait() to value() in some callbacks of PowerSGD communication hook #49709

wants to merge 4 commits into from

Commits on Dec 21, 2020

  1. [Gradient Comrpession] Change wait() to vale() in some callbacks used… 

    … in PowerSGD

Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again.

Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202

Differential Revision: [D25672068](https://our.internmc.facebook.com/intern/diff/D25672068/)

[ghstack-poisoned]
    wayi committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    167eb5f View commit details
    Browse the repository at this point in the history

  2. Update on "[Gradient Compression] Change wait() to value() in some ca… 

    …llbacks of PowerSGD communication hook"


Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again.

Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202

Differential Revision: [D25672068](https://our.internmc.facebook.com/intern/diff/D25672068/)

[ghstack-poisoned]
    wayi committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    785c7cb View commit details
    Browse the repository at this point in the history

  3. Update on "[Gradient Compression] Change wait() to value() in some ca… 

    …llbacks of PowerSGD communication hook"


Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again.

Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202

Differential Revision: [D25672068](https://our.internmc.facebook.com/intern/diff/D25672068/)

[ghstack-poisoned]
    wayi committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    7ba5030 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. Update on "[Gradient Compression] Change wait() to value() in some ca… 

    …llbacks of PowerSGD communication hook"


Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again.

Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202

Differential Revision: [D25672068](https://our.internmc.facebook.com/intern/diff/D25672068/)

[ghstack-poisoned]
    wayi committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    838d1f6 View commit details
    Browse the repository at this point in the history