New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gradient Compression] Change wait() to value() in some callbacks of PowerSGD communication hook #49709
Conversation
… in PowerSGD Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again. Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D25672068](https://our.internmc.facebook.com/intern/diff/D25672068/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 838d1f6 (more details on the Dr. CI page):
🕵️ 3 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_linux_xenial_py3_6_gcc5_4_build (1/3)Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)
|
…llbacks of PowerSGD communication hook" Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again. Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D25672068](https://our.internmc.facebook.com/intern/diff/D25672068/) [ghstack-poisoned]
…llbacks of PowerSGD communication hook" Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again. Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D25672068](https://our.internmc.facebook.com/intern/diff/D25672068/) [ghstack-poisoned]
…llbacks of PowerSGD communication hook" Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again. Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D25672068](https://our.internmc.facebook.com/intern/diff/D25672068/) [ghstack-poisoned]
This pull request has been merged in af1b636. |
Stack from ghstack:
Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again.
Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202
Differential Revision: D25672068