Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gradient Compression] Change wait() to value() in some callbacks of PowerSGD communication hook #49709

Closed
wants to merge 4 commits into from

Conversation

wayi1
Copy link
Contributor

@wayi1 wayi1 commented Dec 21, 2020

Stack from ghstack:

Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again.

Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202

Differential Revision: D25672068

… in PowerSGD

Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again.

Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202

Differential Revision: [D25672068](https://our.internmc.facebook.com/intern/diff/D25672068/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 21, 2020

💊 CI failures summary and remediations

As of commit 838d1f6 (more details on the Dr. CI page):


  • 4/4 failures possibly* introduced in this PR
    • 1/4 non-CircleCI failure(s)

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (1/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 838d1f6f27 Update on "[Gradient Compression] Change wait() to value() in some callbacks of PowerSGD communication hook"
+ git reset --hard 838d1f6f270d25da6d4aa55b99a574cba44ba76f
HEAD is now at 838d1f6f27 Update on "[Gradient Compression] Change wait() to value() in some callbacks of PowerSGD communication hook"
+ git merge --allow-unrelated-histories --no-edit --no-ff 7b4a7661d6de659c8423015a2f3e93308eb83850
Auto-merging torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
CONFLICT (content): Merge conflict in torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (2/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 838d1f6f27 Update on "[Gradient Compression] Change wait() to value() in some callbacks of PowerSGD communication hook"
+ git reset --hard 838d1f6f270d25da6d4aa55b99a574cba44ba76f
HEAD is now at 838d1f6f27 Update on "[Gradient Compression] Change wait() to value() in some callbacks of PowerSGD communication hook"
+ git merge --allow-unrelated-histories --no-edit --no-ff 7b4a7661d6de659c8423015a2f3e93308eb83850
Auto-merging torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
CONFLICT (content): Merge conflict in torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build (3/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 838d1f6f27 Update on "[Gradient Compression] Change wait() to value() in some callbacks of PowerSGD communication hook"
+ git reset --hard 838d1f6f270d25da6d4aa55b99a574cba44ba76f
HEAD is now at 838d1f6f27 Update on "[Gradient Compression] Change wait() to value() in some callbacks of PowerSGD communication hook"
+ git merge --allow-unrelated-histories --no-edit --no-ff 7b4a7661d6de659c8423015a2f3e93308eb83850
Auto-merging torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
CONFLICT (content): Merge conflict in torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 14 times.

@wayi1 wayi1 changed the title [Gradient Comrpession] Change wait() to vale() in some callbacks used in PowerSGD [Gradient Compression] Change wait() to value() in some callbacks of PowerSGD communication hook Dec 21, 2020
…llbacks of PowerSGD communication hook"


Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again.

Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202

Differential Revision: [D25672068](https://our.internmc.facebook.com/intern/diff/D25672068/)

[ghstack-poisoned]
…llbacks of PowerSGD communication hook"


Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again.

Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202

Differential Revision: [D25672068](https://our.internmc.facebook.com/intern/diff/D25672068/)

[ghstack-poisoned]
…llbacks of PowerSGD communication hook"


Since wait() has already been called in the return statements of the precursor callbacks, no need to wait again.

Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202

Differential Revision: [D25672068](https://our.internmc.facebook.com/intern/diff/D25672068/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in af1b636.

@facebook-github-bot facebook-github-bot deleted the gh/SciPioneer/40/head branch December 26, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants