-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up some type annotations in benchmarks/fastrnns #49946
Conversation
💊 CI failures summary and remediationsAs of commit 1f2e7ca (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This pull request was exported from Phabricator. Differential Revision: D25717510 |
Codecov Report
@@ Coverage Diff @@
## master #49946 +/- ##
==========================================
- Coverage 80.72% 80.72% -0.01%
==========================================
Files 1909 1909
Lines 207051 207051
==========================================
- Hits 167144 167138 -6
- Misses 39907 39913 +6 |
This pull request was exported from Phabricator. Differential Revision: D25717510 |
31271b3
to
ec37b9e
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
ec37b9e
to
c219846
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
c219846
to
3821c6e
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
3821c6e
to
39705d2
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
39705d2
to
5de3f09
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
5de3f09
to
ba17813
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
ba17813
to
056ffca
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
056ffca
to
45893d4
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
5a90af9
to
06f9a23
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
06f9a23
to
61a0c80
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
61a0c80
to
e8a92c2
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
e8a92c2
to
a6304d3
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
a6304d3
to
15813c5
Compare
This pull request was exported from Phabricator. Differential Revision: D25717510 |
15813c5
to
58b0dde
Compare
…ytorch#49946) Summary: Pull Request resolved: pytorch#49946 Upgrades type annotations from Python2 to Python3 Test Plan: Sandcastle tests Differential Revision: D25717510 fbshipit-source-id: 0b9402ed296e6c0cdc91cda00b1245e1e9ece8f4
This pull request was exported from Phabricator. Differential Revision: D25717510 |
58b0dde
to
1f2e7ca
Compare
This pull request has been merged in 7d0eecc. |
Unlanding. Looks like this is causing build failures like this:
|
This pull request has been reverted by 2639f1d. |
@mruberry : Sorry about that. The diff passed all tests everywhere before I landed. Any suggestions for testing this more thoroughly during my fix-resubmit cycle? |
@r-barnes Running the edited code paths locally might have revealed the issue, but the failure in CI was masked by an infra failure, which we don't typically block on. |
Summary: Upgrades type annotations from Python2 to Python3
Test Plan: Sandcastle tests
Differential Revision: D25717510