New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some type annotations in benchmarks/fastrnns #49946

Closed

r-barnes wants to merge 1 commit into pytorch:master from r-barnes:export-D25717510

Contributor

r-barnes commented Dec 29, 2020

Summary: Upgrades type annotations from Python2 to Python3

Test Plan: Sandcastle tests

Differential Revision: D25717510

Contributor

facebook-github-bot commented Dec 29, 2020 •

edited

Loading

💊 CI failures summary and remediations

As of commit 1f2e7ca (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

facebook-github-bot added cla signed fb-exported labels

Contributor

facebook-github-bot commented Dec 29, 2020

This pull request was exported from Phabricator. Differential Revision: D25717510

codecov bot commented Dec 30, 2020 •

edited

Loading

Codecov Report

Merging #49946 (1f2e7ca) into master (cf45d65) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #49946      +/-   ##
==========================================
- Coverage   80.72%   80.72%   -0.01%     
==========================================
  Files        1909     1909              
  Lines      207051   207051              
==========================================
- Hits       167144   167138       -6     
- Misses      39907    39913       +6

Contributor

facebook-github-bot commented Dec 30, 2020

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from 31271b3 to ec37b9e Compare

December 30, 2020 00:23

Contributor

facebook-github-bot commented Dec 30, 2020

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from ec37b9e to c219846 Compare

December 30, 2020 01:35

Contributor

facebook-github-bot commented Dec 30, 2020

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from c219846 to 3821c6e Compare

December 30, 2020 17:24

Contributor

facebook-github-bot commented Dec 30, 2020

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from 3821c6e to 39705d2 Compare

December 30, 2020 17:29

Contributor

facebook-github-bot commented Dec 30, 2020

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from 39705d2 to 5de3f09 Compare

December 30, 2020 20:28

Contributor

facebook-github-bot commented Jan 4, 2021

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from 5de3f09 to ba17813 Compare

January 4, 2021 19:29

Contributor

facebook-github-bot commented Jan 4, 2021

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from ba17813 to 056ffca Compare

January 4, 2021 22:44

Contributor

facebook-github-bot commented Jan 4, 2021

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from 056ffca to 45893d4 Compare

January 4, 2021 23:00

Contributor

facebook-github-bot commented Jan 5, 2021

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from 5a90af9 to 06f9a23 Compare

January 6, 2021 18:45

Contributor

facebook-github-bot commented Jan 6, 2021

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from 06f9a23 to 61a0c80 Compare

January 6, 2021 20:15

Contributor

facebook-github-bot commented Jan 7, 2021

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from 61a0c80 to e8a92c2 Compare

January 7, 2021 19:18

Contributor

facebook-github-bot commented Jan 7, 2021

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from e8a92c2 to a6304d3 Compare

January 7, 2021 19:35

Contributor

facebook-github-bot commented Jan 8, 2021

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from a6304d3 to 15813c5 Compare

January 8, 2021 06:10

Contributor

facebook-github-bot commented Jan 8, 2021

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from 15813c5 to 58b0dde Compare

January 8, 2021 18:51


          [Don't review] Clean up some type annotations in benchmarks/fastrnns (p…

1f2e7ca

…ytorch#49946)

Summary:
Pull Request resolved: pytorch#49946

Upgrades type annotations from Python2 to Python3

Test Plan: Sandcastle tests

Differential Revision: D25717510

fbshipit-source-id: 0b9402ed296e6c0cdc91cda00b1245e1e9ece8f4

Contributor

facebook-github-bot commented Jan 12, 2021

This pull request was exported from Phabricator. Differential Revision: D25717510

r-barnes force-pushed the export-D25717510 branch from 58b0dde to 1f2e7ca Compare

January 12, 2021 21:37

facebook-github-bot closed this in

7d0eecc

Contributor

facebook-github-bot commented Jan 13, 2021

This pull request has been merged in 7d0eecc.

facebook-github-bot added the Merged label

malfet mentioned this pull request

Fix fastrnn benchmark regression introduced by 49946 #50517

Closed

facebook-github-bot pushed a commit that referenced this pull request


          Fix fastrnn benchmark regression introduced by 49946 (#50517)

a3f9cf9

Summary:
Simply add missing `from typing import List, Tuple` and `from torch import Tensor`

Fixes regression introduced by #49946

Pull Request resolved: #50517

Reviewed By: gchanan

Differential Revision: D25908379

Pulled By: malfet

fbshipit-source-id: a44b96681b6121e61b69f960f81c0cad3f2a8d20

Collaborator

mruberry commented Jan 14, 2021

Unlanding. Looks like this is causing build failures like this:

Jan 14 00:15:36 ImportError while loading conftest '/var/lib/jenkins/workspace/benchmarks/fastrnns/conftest.py'.
Jan 14 00:15:36 benchmarks/fastrnns/__init__.py:1: in <module>
Jan 14 00:15:36     from .cells import *
Jan 14 00:15:36 benchmarks/fastrnns/cells.py:25: in <module>
Jan 14 00:15:36     def lstm_cell(input: Tensor, hidden: Tuple[Tensor, Tensor], w_ih: Tensor,
Jan 14 00:15:36 E   NameError: name 'Tensor' is not defined

Contributor

facebook-github-bot commented Jan 14, 2021

This pull request has been reverted by 2639f1d.

facebook-github-bot added the Reverted label

Contributor Author

r-barnes commented Jan 14, 2021

@mruberry : Sorry about that. The diff passed all tests everywhere before I landed. Any suggestions for testing this more thoroughly during my fix-resubmit cycle?

Collaborator

mruberry commented Jan 14, 2021

@r-barnes Running the edited code paths locally might have revealed the issue, but the failure in CI was masked by an infra failure, which we don't typically block on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed fb-exported Merged Reverted