-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement python API for AdaBelief optimizer #50157
Conversation
💊 CI failures summary and remediationsAs of commit 92938c6 (more details on the Dr. CI page):
🕵️ 7 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_linux_bionic_py3_8_gcc9_coverage_test1 (1/7)Step: "Run tests" (full log | diagnosis details | 🔁 rerun)
|
…pytorch into adabelief_python
@juntang-zhuang here is the link: #47571 |
@glaringlee Thanks a lot for the update. I'll just keep the changes in my local repository so we can consider merging it later. |
Sure, let's revisit this in the middle of the year see whether you have more citations, or if you optimizer is used by a large facility (eg, some big companies?), I think that would be a big plus. let's see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for proposing AdaBelief implementation to PyTorch Core Library.
We would want to refer to rulebook for adding optimizers to PyTorch Core:
https://github.com/pytorch/pytorch/wiki/Developer-FAQ#i-have-implemented-an-algorithm--feature-from-a-research-paper-that-is-related-to-optimization-when-is-the-correct-time-to-add-it-to-pytorch-core-
Which implies although AdaBelief is a very promising algorithm, given that it's relatively new algorithm we cannot add it to Core Library yet.
It can be interesting discussion to return back to this issue in the following years.
Fixes #47571 partially, add python API for AdaBelief optimizer.