[ONNX] ONNX dev branch merge 01-06-2021 #50163

spandantiwari · 2021-01-06T22:18:35Z

[ONNX] ONNX dev branch merge 01-06-2021

[ONNX] Support onnx if/loop sequence output in opset 13 - ([ONNX] Support onnx if/loop sequence output in opset 13 - dev #49270)
Symbolic function for torch.square ([ONNX] Symbolic function for torch.square #49446)
[ONNX] Add checks in ONNXSetDynamicInputShape ([ONNX] Add checks in ONNXSetDynamicInputShape #49783) …
[ONNX] Enable export af aten::__derive_index ([ONNX] Enable export af aten::__derive_index #49514) …
[ONNX] Update symbolic for unfold ([ONNX] Update symbolic for unfold #49378) …
[ONNX] Update the sequence of initializers in exported graph so that it is as same as inputs. ([ONNX] Update the sequence of initializers in exported graph so that it is as same as inputs. #49798)
[ONNX] Enable opset 13 ops ([ONNX] Enable opset 13 ops #49612) …
[ONNX] Improve error message for supported model input types in ONNX export API. ([ONNX] Improve error message for supported model input types in ONNX export API #50119)
[ONNX] Add a post-pass for If folding ([ONNX] Add a post-pass for If folding #49410)

facebook-github-bot · 2021-01-06T22:18:52Z

💊 CI failures summary and remediations

As of commit 795c9e1 (more details on the Dr. CI page):

2/2 failures possibly* introduced in this PR
- 2/2 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

Failed: pr/caffe2-pytorch-linux-bionic-rocm3.10-py3.6-test

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 11 times.

codecov · 2021-01-07T02:04:28Z

Codecov Report

Merging #50163 (795c9e1) into master (aa18d17) will decrease coverage by 0.04%.
The diff coverage is 70.92%.

@@            Coverage Diff             @@
##           master   #50163      +/-   ##
==========================================
- Coverage   80.68%   80.64%   -0.05%     
==========================================
  Files        1904     1906       +2     
  Lines      206555   207383     +828     
==========================================
+ Hits       166667   167250     +583     
- Misses      39888    40133     +245

facebook-github-bot

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

SplitInfinity · 2021-01-07T04:28:20Z

Just a heads up - unless this stack is created with ghstack, our tooling will squash all these commits into one. The title and body for that commit will be taken from the title of this PR and the contents of your first comment.

spandantiwari · 2021-01-07T17:59:58Z

Just a heads up - unless this stack is created with ghstack, our tooling will squash all these commits into one. The title and body for that commit will be taken from the title of this PR and the contents of your first comment.

Hi @SplitInfinity - Thanks for the heads up. Is there no way to capture the commits separately? At the very least, can we put a commit message which captures the titles of main commits as sub-bullets (manually entered)?

So, a message like this:

[ONNX] ONNX dev branch merge 01-06-2021

[ONNX] Support onnx if/loop sequence output in opset 13 - ([ONNX] Support onnx if/loop sequence output in opset 13 - dev #49270)
Symbolic function for torch.square ([ONNX] Symbolic function for torch.square #49446)
[ONNX] Add checks in ONNXSetDynamicInputShape ([ONNX] Add checks in ONNXSetDynamicInputShape #49783) …
[ONNX] Enable export af aten::__derive_index ([ONNX] Enable export af aten::__derive_index #49514) …
[ONNX] Update symbolic for unfold ([ONNX] Update symbolic for unfold #49378) …
[ONNX] Update the sequence of initializers in exported graph so that it is as same as inputs. ([ONNX] Update the sequence of initializers in exported graph so that it is as same as inputs. #49798)
[ONNX] Enable opset 13 ops ([ONNX] Enable opset 13 ops #49612) …
[ONNX] Improve error message for supported model input types in ONNX export API. ([ONNX] Improve error message for supported model input types in ONNX export API #50119)

SplitInfinity · 2021-01-07T18:02:04Z

Is there no way to capture the commits separately?

ghstack is the way.

At the very least, can we put a commit message which captures the titles of main commits as sub-bullets (manually entered)?

Yes. Edit the contents of your first comment in this thread to include such a list, and that's what will be included in the commit message by our tooling.

facebook-github-bot

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

SplitInfinity · 2021-01-07T23:19:36Z

#50237 is attempting to make a similar change to one of the commits in this stack. If that lands first (which it likely will since it's smaller), you'll have to rebase.

spandantiwari · 2021-01-08T21:26:13Z

#50237 is attempting to make a similar change to one of the commits in this stack. If that lands first (which it likely will since it's smaller), you'll have to rebase.

Thanks @SplitInfinity. Now that #50237 has been merged, I will update this PR.

)

* [ONNX] Add checks in ONNXSetDynamicInputShape * [ONNX] Add checks in ONNXSetDynamicInputShape

* Add derive_index * Add derive_index test * Adding more tests * Update symbolic_opset9.py

* update symbolic for unfold * update symbolic_opse12 file * update symbolic_opse12 file * [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270) * Symbolic function for torch.square (pytorch#49446) * instead of a pass use a helper function * update ort version * Revert "instead of a pass use a helper function" This reverts commit 723b446. * update symbolics * update symbolic * update symbolics * [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270) * Symbolic function for torch.square (pytorch#49446) * empty commit * fix clang-tidy * fix clang-tidy Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: David Fan <30608893+jiafatom@users.noreply.github.com>

…it is as same as inputs. (pytorch#49798) * [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270) * Symbolic function for torch.square (pytorch#49446) * [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270) * Symbolic function for torch.square (pytorch#49446) * Update code so that initializers' sequence is as same as inputs. * Correct the format according to flake8. * Correct the format by clang-format. * Add a new test for script model. * Update expect files for Test_Operators tests. Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: David Fan <30608893+jiafatom@users.noreply.github.com>

* Enable opset 13 ORT tests * Update test.sh * Set environ var * Update test.sh * Enabling more ops for opset 13 * change master to main * Update symbolic_opset13.py * Flake 8 fix * [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270) * Symbolic function for torch.square (pytorch#49446) * Clean up tests * Exclude more tests * Trigge build * [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270) * Symbolic function for torch.square (pytorch#49446) * update ORT version * disable more tests * clean up * flake8 * Disable TV tests * Update test_pytorch_onnx_onnxruntime.py Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: David Fan <30608893+jiafatom@users.noreply.github.com>

…export API. (pytorch#50119)

* add pass * add tests * enable tests * update dtype symbolic * update pass * clang format * update utils file * fix clang_tidy errors * update pass * update pass * clang format * update pass * update pass * update pass * update pass * update pass * update pass * update pass * update pass * fix mypy tests * update comment * update pass * add new line * update pass * empty commit * empty commit * fix merge conflict

spandantiwari · 2021-01-09T00:06:27Z

#50237 is attempting to make a similar change to one of the commits in this stack. If that lands first (which it likely will since it's smaller), you'll have to rebase.

Thanks @SplitInfinity. Now that #50237 has been merged, I will update this PR.

Rebased and reconciled with latest master, including #50237.

facebook-github-bot

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

SplitInfinity · 2021-01-10T06:28:11Z

@spandantiwari pytorch_linux_xenial_py3_clang7_onnx_ort_test2 appears to have failed. Can you take a look?

spandantiwari · 2021-01-11T17:54:33Z

@spandantiwari pytorch_linux_xenial_py3_clang7_onnx_ort_test2 appears to have failed. Can you take a look?

Thanks @SplitInfinity, we are taking a look.

spandantiwari · 2021-01-11T20:05:18Z

@spandantiwari pytorch_linux_xenial_py3_clang7_onnx_ort_test2 appears to have failed. Can you take a look?

Thanks @SplitInfinity, we are taking a look.
Updated PR with fix for failing test.

spandantiwari · 2021-01-12T00:18:26Z

@SplitInfinity - We have fixed the test failure. In the latest CI, there's a test failing, but it seems unrelated to this PR. In fact we found a couple of other PRs which are seeing the same failure (#50155, #50157), which probably points towards some unrelated issue.
Given that, would it be possible to go ahead with the merge?

facebook-github-bot

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

SplitInfinity · 2021-01-12T00:22:10Z

@SplitInfinity - We have fixed the test failure. In the latest CI, there's a test failing, but it seems unrelated to this PR. In fact we found a couple of other PRs which are seeing the same failure (#50155, #50157), which probably points towards some unrelated issue.
Given that, would it be possible to go ahead with the merge?

Yeah, those tests look unrelated. I imported the diff again, I'll let you know how the internal tests look.

spandantiwari · 2021-01-12T18:07:41Z

Yeah, those tests look unrelated. I imported the diff again, I'll let you know how the internal tests look.

Thanks @SplitInfinity . :-)
Let me know if there's anything else needed here.

facebook-github-bot

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-01-13T21:56:27Z

@SplitInfinity merged this pull request in aeefe2c.

facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Jan 6, 2021

pytorchbot added the open source label Jan 6, 2021

H-Huang added module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jan 7, 2021

H-Huang requested review from BowenBao and SplitInfinity January 7, 2021 00:57

facebook-github-bot reviewed Jan 7, 2021

View reviewed changes

BowenBao and others added 9 commits January 8, 2021 15:29

[ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270

63a76bd

)

Symbolic function for torch.square (pytorch#49446)

3493457

[ONNX] Add checks in ONNXSetDynamicInputShape (pytorch#49783)

4db8cb4

* [ONNX] Add checks in ONNXSetDynamicInputShape * [ONNX] Add checks in ONNXSetDynamicInputShape

[ONNX] Enable export af aten::__derive_index (pytorch#49514)

57d2c58

* Add derive_index * Add derive_index test * Adding more tests * Update symbolic_opset9.py

[ONNX] Improve error message for supported model input types in ONNX …

e77ff2a

…export API. (pytorch#50119)

spandantiwari force-pushed the onnx_ms_1 branch from 33f26ed to 7b920b0 Compare January 8, 2021 23:56

facebook-github-bot reviewed Jan 9, 2021

View reviewed changes

Update test_copy to prevent Opset 13 test.

795c9e1

facebook-github-bot reviewed Jan 12, 2021

View reviewed changes

facebook-github-bot closed this in aeefe2c Jan 13, 2021

facebook-github-bot added the Merged label Jan 13, 2021

jiafatom mentioned this pull request Jan 15, 2021

ONNX tests failing on master pytorch/vision#3251

Closed

neginraoof mentioned this pull request Jan 19, 2021

"Unsupported: ONNX export of transpose for tensor of unknown rank." with dynamic axes #50686

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ONNX] ONNX dev branch merge 01-06-2021 #50163

[ONNX] ONNX dev branch merge 01-06-2021 #50163

spandantiwari commented Jan 6, 2021 •

edited

facebook-github-bot commented Jan 6, 2021 •

edited

codecov bot commented Jan 7, 2021 •

edited

facebook-github-bot left a comment

SplitInfinity commented Jan 7, 2021

spandantiwari commented Jan 7, 2021

SplitInfinity commented Jan 7, 2021

facebook-github-bot left a comment

SplitInfinity commented Jan 7, 2021

spandantiwari commented Jan 8, 2021

spandantiwari commented Jan 9, 2021

facebook-github-bot left a comment

SplitInfinity commented Jan 10, 2021

spandantiwari commented Jan 11, 2021

spandantiwari commented Jan 11, 2021

spandantiwari commented Jan 12, 2021

facebook-github-bot left a comment

SplitInfinity commented Jan 12, 2021

spandantiwari commented Jan 12, 2021

facebook-github-bot left a comment

facebook-github-bot commented Jan 13, 2021

[ONNX] ONNX dev branch merge 01-06-2021 #50163

[ONNX] ONNX dev branch merge 01-06-2021 #50163

Conversation

spandantiwari commented Jan 6, 2021 • edited

facebook-github-bot commented Jan 6, 2021 • edited

💊 CI failures summary and remediations

ci.pytorch.org: 1 failed

codecov bot commented Jan 7, 2021 • edited

Codecov Report

facebook-github-bot left a comment

Choose a reason for hiding this comment

SplitInfinity commented Jan 7, 2021

spandantiwari commented Jan 7, 2021

SplitInfinity commented Jan 7, 2021

facebook-github-bot left a comment

Choose a reason for hiding this comment

SplitInfinity commented Jan 7, 2021

spandantiwari commented Jan 8, 2021

spandantiwari commented Jan 9, 2021

facebook-github-bot left a comment

Choose a reason for hiding this comment

SplitInfinity commented Jan 10, 2021

spandantiwari commented Jan 11, 2021

spandantiwari commented Jan 11, 2021

spandantiwari commented Jan 12, 2021

facebook-github-bot left a comment

Choose a reason for hiding this comment

SplitInfinity commented Jan 12, 2021

spandantiwari commented Jan 12, 2021

facebook-github-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Jan 13, 2021

spandantiwari commented Jan 6, 2021 •

edited

facebook-github-bot commented Jan 6, 2021 •

edited

codecov bot commented Jan 7, 2021 •

edited