Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Devirtualize TensorImpl::sizes() with macro #50176

Closed
wants to merge 3 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 7, 2021

Stack from ghstack:

UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it.

Differential Revision: D25817370

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it.

Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 7, 2021

💊 CI failures summary and remediations

As of commit c7ad841 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_bazel_build (1/1)

Step: "Bazel Build" (full log | diagnosis details | 🔁 rerun)

Jan 08 21:00:12 FAILED: Build did NOT complete successfully (38 packages loaded, 5435 targets configured)
Jan 08 21:00:12 Repository rule http_archive defined at:
Jan 08 21:00:12   /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/external/bazel_tools/tools/build_defs/repo/http.bzl:336:16: in <toplevel>
Jan 08 21:00:12 WARNING: Download from https://anaconda.org/anaconda/mkl/2020.0/download/linux-64/mkl-2020.0-166.tar.bz2 failed: class java.io.IOException Read timed out
Jan 08 21:00:12 ERROR: An error occurred during the fetch of repository 'mkl':
Jan 08 21:00:12    java.io.IOException: Error downloading [https://anaconda.org/anaconda/mkl/2020.0/download/linux-64/mkl-2020.0-166.tar.bz2] to /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/external/mkl/mkl-2020.0-166.tar.bz2: Read timed out
Jan 08 21:00:12 ERROR: /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/external/mkl_dnn/BUILD.bazel:28:1: @mkl_dnn//:mkl-dnn depends on @mkl//:mkl in repository @mkl which failed to fetch. no such package '@mkl//': java.io.IOException: Error downloading [https://anaconda.org/anaconda/mkl/2020.0/download/linux-64/mkl-2020.0-166.tar.bz2] to /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/external/mkl/mkl-2020.0-166.tar.bz2: Read timed out
Jan 08 21:00:12 ERROR: Analysis of target '//:torch' failed; build aborted: no such package '@mkl//': java.io.IOException: Error downloading [https://anaconda.org/anaconda/mkl/2020.0/download/linux-64/mkl-2020.0-166.tar.bz2] to /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/external/mkl/mkl-2020.0-166.tar.bz2: Read timed out
Jan 08 21:00:12 INFO: Elapsed time: 155.901s
Jan 08 21:00:12 INFO: 0 processes.
Jan 08 21:00:12 FAILED: Build did NOT complete successfully (38 packages loaded, 5435 targets configured)
Jan 08 21:00:12 FAILED: Build did NOT complete successfully (38 packages loaded, 5435 targets configured)
Jan 08 21:00:12 + cleanup
Jan 08 21:00:12 + retcode=1
Jan 08 21:00:12 + set +x
Jan 08 21:00:12 =================== sccache compilation log ===================
Jan 08 21:00:12 ERROR 2021-01-08T20:57:45Z: sccache::server: ["null"] fatal error: Permission denied (os error 13) at path "/dev/.tmpQnT2rn"
Jan 08 21:00:12 
Jan 08 21:00:12 ERROR 2021-01-08T20:57:45Z: sccache::server: ["null"] 	Permission denied (os error 13) at path "/dev/.tmpQnT2rn"
Jan 08 21:00:12 
Jan 08 21:00:12 ERROR 2021-01-08T20:57:45Z: sccache::server: ["null"] fatal error: Permission denied (os error 13) at path "/dev/.tmpeKauVC"
Jan 08 21:00:12 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 10 times.

swolchok added a commit that referenced this pull request Jan 7, 2021
UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it.

Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)!

ghstack-source-id: 119496141
Pull Request resolved: #50176
UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it.

Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)!

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 7, 2021
Pull Request resolved: #50176

UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it.
ghstack-source-id: 119528063

Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)!
@swolchok swolchok added the module: bc-breaking Related to a BC-breaking change label Jan 7, 2021
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing that sizes_ is still initialized in undefined tensor (so we don't return garbage)

UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it.

Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)!

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 8, 2021
Pull Request resolved: #50176

UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it.
ghstack-source-id: 119609531

Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)!
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b5d3826.

@facebook-github-bot facebook-github-bot deleted the gh/swolchok/66/head branch January 16, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged module: bc-breaking Related to a BC-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants