New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PyTorch] Devirtualize TensorImpl::sizes() with macro #50176
Conversation
UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it. Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)! [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit c7ad841 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_bazel_build (1/1)Step: "Bazel Build" (full log | diagnosis details | 🔁 rerun)
|
UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it. Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)! ghstack-source-id: 119496141 Pull Request resolved: #50176
UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it. Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)! [ghstack-poisoned]
Pull Request resolved: #50176 UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it. ghstack-source-id: 119528063 Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guessing that sizes_
is still initialized in undefined tensor (so we don't return garbage)
UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it. Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)! [ghstack-poisoned]
Pull Request resolved: #50176 UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it. ghstack-source-id: 119609531 Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)!
This pull request has been merged in b5d3826. |
Stack from ghstack:
UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it.
Differential Revision: D25817370
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!