New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch] Devirtualize TensorImpl::sizes() with macro #50176

Closed

swolchok wants to merge 3 commits into gh/swolchok/66/base from gh/swolchok/66/head

Commits on Jan 7, 2021

[PyTorch] Devirtualize TensorImpl::sizes() with macro

UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it.

Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)!

[ghstack-poisoned]

swolchok committed Jan 7, 2021

Update on "[PyTorch] Devirtualize TensorImpl::sizes() with macro"

UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it.

Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)!

[ghstack-poisoned]

swolchok committed Jan 7, 2021

Commits on Jan 8, 2021

Update on "[PyTorch] Devirtualize TensorImpl::sizes() with macro"

UndefinedTensorImpl was the only type that overrode this, and IIUC we don't need to do it.

Differential Revision: [D25817370](https://our.internmc.facebook.com/intern/diff/D25817370/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25817370/)!

[ghstack-poisoned]

swolchok committed Jan 8, 2021