[RPC] Support timeout in rref._get_type() #50498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is mostly needed for the next diff in this stack, where rref._get_type() is called in the rpc_async/rpc_sync RRef proxy function and can block indefinitely if there is no timeout. It will also be useful to have a timeout argument when we publicize this API to keep it consistent with other RPC APIs. Differential Revision: [D25897588](https://our.internmc.facebook.com/intern/diff/D25897588/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25897588/)! [ghstack-poisoned]
rohan-varma
requested review from
mingzhe09088,
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
💊 CI failures summary and remediationsAs of commit 38fc8d5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## gh/rohan-varma/215/base #50498 +/- ##
===========================================================
+ Coverage 80.67% 80.73% +0.05%
===========================================================
Files 1910 1910
Lines 207842 207195 -647
===========================================================
- Hits 167684 167273 -411
+ Misses 40158 39922 -236 |
pritamdamania87
approved these changes
Jan 15, 2021
torch/csrc/distributed/rpc/init.cpp
Outdated
Comment on lines
387
to
391
| timeout (float, optional): Timeout for ``_get_type``. If | ||
| the call does not complete within this timeframe, an | ||
| exception indicating so will be raised. If this | ||
| argument is not provided, the default RPC timeout will | ||
| be used. |
There was a problem hiding this comment.
The doc should mention the unit for the timeout (seconds/milliseconds etc.)
This change is mostly needed for the next diff in this stack, where rref._get_type() is called in the rpc_async/rpc_sync RRef proxy function and can block indefinitely if there is no timeout. It will also be useful to have a timeout argument when we publicize this API to keep it consistent with other RPC APIs. Differential Revision: [D25897588](https://our.internmc.facebook.com/intern/diff/D25897588/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25897588/)! [ghstack-poisoned]
This change is mostly needed for the next diff in this stack, where rref._get_type() is called in the rpc_async/rpc_sync RRef proxy function and can block indefinitely if there is no timeout. It will also be useful to have a timeout argument when we publicize this API to keep it consistent with other RPC APIs. Differential Revision: [D25897588](https://our.internmc.facebook.com/intern/diff/D25897588/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25897588/)! [ghstack-poisoned]
|
This pull request has been merged in ab1ba8f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This change is mostly needed for the next diff in this stack, where
rref._get_type() is called in the rpc_async/rpc_sync RRef proxy function and
can block indefinitely if there is no timeout. It will also be useful to have a
timeout argument when we publicize this API to keep it consistent with other
RPC APIs.
Differential Revision: D25897588
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!