Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPC] Support timeout in rref._get_type() #50498

Closed
wants to merge 3 commits into from
Closed

[RPC] Support timeout in rref._get_type() #50498

wants to merge 3 commits into from

Commits on Jan 13, 2021

  1. [RPC] Support timeout in rref._get_type() 

    This change is mostly needed for the next diff in this stack, where
rref._get_type() is called in the rpc_async/rpc_sync RRef proxy function and
can block indefinitely if there is no timeout. It will also be useful to have a
timeout argument when we publicize this API to keep it consistent with other
RPC APIs.

Differential Revision: [D25897588](https://our.internmc.facebook.com/intern/diff/D25897588/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25897588/)!

[ghstack-poisoned]
    @rohan-varma
    rohan-varma committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    38fc8d5 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Update on "[RPC] Support timeout in rref._get_type()" 

    This change is mostly needed for the next diff in this stack, where
rref._get_type() is called in the rpc_async/rpc_sync RRef proxy function and
can block indefinitely if there is no timeout. It will also be useful to have a
timeout argument when we publicize this API to keep it consistent with other
RPC APIs.

Differential Revision: [D25897588](https://our.internmc.facebook.com/intern/diff/D25897588/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25897588/)!

[ghstack-poisoned]
    @rohan-varma
    rohan-varma committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    e5449cb View commit details
    Browse the repository at this point in the history

  2. Update on "[RPC] Support timeout in rref._get_type()" 

    This change is mostly needed for the next diff in this stack, where
rref._get_type() is called in the rpc_async/rpc_sync RRef proxy function and
can block indefinitely if there is no timeout. It will also be useful to have a
timeout argument when we publicize this API to keep it consistent with other
RPC APIs.

Differential Revision: [D25897588](https://our.internmc.facebook.com/intern/diff/D25897588/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25897588/)!

[ghstack-poisoned]
    @rohan-varma
    rohan-varma committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    812ac3f View commit details
    Browse the repository at this point in the history