[dist_optim] add distributed functional sgd optimizer #50618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
wanchaol
requested review from
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
This was referenced Jan 15, 2021
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Jan 15, 2021
rohan-varma
approved these changes
Jan 19, 2021
| @@ -207,3 +207,5 @@ def test_dist_optim(self): | |||
| def test_dist_optim_functional(self): | |||
| self._test_dist_optim_base(optim.Adagrad, lr=0.05) | |||
| self._test_dist_optim_base(optim.Adam, lr=1e-2, amsgrad=True) | |||
| self._test_dist_optim_base(optim.SGD, lr=0.05) | |||
There was a problem hiding this comment.
Is this test now duplicated with the one on line 203 of this file?
There was a problem hiding this comment.
Yes you are right, right now we are defaulting to use the torchscripted version of optimizer, let me merge these two.
Differential Revision: [D25932778](https://our.internmc.facebook.com/intern/diff/D25932778) [ghstack-poisoned]
Differential Revision: [D25932778](https://our.internmc.facebook.com/intern/diff/D25932778) [ghstack-poisoned]
Differential Revision: [D25932778](https://our.internmc.facebook.com/intern/diff/D25932778) [ghstack-poisoned]
Differential Revision: [D25932778](https://our.internmc.facebook.com/intern/diff/D25932778) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D25932778