Skip to content

Conversation

@wanchaol
Copy link
Collaborator

@wanchaol wanchaol commented Jan 15, 2021

Stack from ghstack:

Add TorchScript compatible AdamW functional optimizer to distributed optimizer

Differential Revision: D25932774

Add TorchScript compatible AdamW functional optimizer to distributed optimizer

[ghstack-poisoned]
Add TorchScript compatible AdamW functional optimizer to distributed optimizer

[ghstack-poisoned]
Add TorchScript compatible AdamW functional optimizer to distributed optimizer

[ghstack-poisoned]
wanchaol added a commit that referenced this pull request Jan 15, 2021
Add TorchScript compatible AdamW functional optimizer to distributed optimizer

ghstack-source-id: 058e878
Pull Request resolved: #50620
Add TorchScript compatible AdamW functional optimizer to distributed optimizer

Differential Revision: [D25932774](https://our.internmc.facebook.com/intern/diff/D25932774)

[ghstack-poisoned]
Add TorchScript compatible AdamW functional optimizer to distributed optimizer

Differential Revision: [D25932774](https://our.internmc.facebook.com/intern/diff/D25932774)

[ghstack-poisoned]
Add TorchScript compatible AdamW functional optimizer to distributed optimizer

Differential Revision: [D25932774](https://our.internmc.facebook.com/intern/diff/D25932774)

[ghstack-poisoned]
Copy link
Contributor

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mainly checked for parity between this and #50411

Add TorchScript compatible AdamW functional optimizer to distributed optimizer

Differential Revision: [D25932774](https://our.internmc.facebook.com/intern/diff/D25932774)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@wanchaol merged this pull request in 2c3c2a4.

@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/154/head branch January 26, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants