New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create PyTorch DDP logging APIs for applications to use #50637
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add APIs for logging pytorch ddp logging data in applications. Differential Revision: [D25933411](https://our.internmc.facebook.com/intern/diff/D25933411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25933411/)! [ghstack-poisoned]
zhaojuanmao
requested review from
mingzhe09088,
mrshenli,
pritamdamania87 and
rohan-varma
as code owners
January 16, 2021 00:28
facebook-github-bot
added
cla signed
oncall: distributed
Add this issue/PR to distributed oncall triage queue
labels
Jan 16, 2021
zhaojuanmao
added a commit
that referenced
this pull request
Jan 16, 2021
add APIs for logging pytorch ddp logging data in applications. Differential Revision: [D25933411](https://our.internmc.facebook.com/intern/diff/D25933411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25933411/)! ghstack-source-id: 119899629 Pull Request resolved: #50637
zhaojuanmao
changed the title
create a pytorch ddp detailed usage logger for analysis and debug
Create PyTorch DDP logging APIs for applications to use
Jan 16, 2021
rohan-varma
reviewed
Jan 16, 2021
add APIs for logging pytorch ddp logging data in applications. Differential Revision: [D25933411](https://our.internmc.facebook.com/intern/diff/D25933411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25933411/)! [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Jan 24, 2021
Pull Request resolved: #50637 add APIs for logging pytorch ddp logging data in applications. Differential Revision: [D25933411](https://our.internmc.facebook.com/intern/diff/D25933411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25933411/)! ghstack-source-id: 1202762
rohan-varma
approved these changes
Jan 28, 2021
add APIs for logging pytorch ddp logging data in applications. Differential Revision: [D25933411](https://our.internmc.facebook.com/intern/diff/D25933411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25933411/)! [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Jan 29, 2021
Pull Request resolved: #50637 add APIs for logging pytorch ddp logging data in applications. Differential Revision: [D25933411](https://our.internmc.facebook.com/intern/diff/D25933411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25933411/)! ghstack-source-id: 120692215
This was referenced Jan 29, 2021
add APIs for logging pytorch ddp logging data in applications. Differential Revision: [D25933411](https://our.internmc.facebook.com/intern/diff/D25933411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25933411/)! [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Feb 1, 2021
Pull Request resolved: #50637 add APIs for logging pytorch ddp logging data in applications. Differential Revision: [D25933411](https://our.internmc.facebook.com/intern/diff/D25933411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25933411/)! ghstack-source-id: 120799807
add APIs for logging pytorch ddp logging data in applications. Differential Revision: [D25933411](https://our.internmc.facebook.com/intern/diff/D25933411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25933411/)! [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Feb 2, 2021
Pull Request resolved: #50637 add APIs for logging pytorch ddp logging data in applications. Differential Revision: [D25933411](https://our.internmc.facebook.com/intern/diff/D25933411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25933411/)! ghstack-source-id: 120813409
This pull request has been merged in e54cbb8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
add APIs for logging pytorch ddp logging data in applications.
Differential Revision: D25933411
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!