add a c++ interface in processGroup to get its backend name #51066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backend name of a processgroup created using distributed_c10d python API is tracked, but there is no good way to track name of a processgroup created using processGroup c++ API. In some cases, knowing backend name of a processGroup is useful, e,g., log the backend name, or write some codes that have dependency on the known backend. Differential Revision: [D26059769](https://our.internmc.facebook.com/intern/diff/D26059769/) [ghstack-poisoned]
zhaojuanmao
requested review from
mingzhe09088,
mrshenli,
pritamdamania87 and
rohan-varma
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
💊 CI failures summary and remediationsAs of commit f673853 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
zhaojuanmao
added a commit
that referenced
this pull request
Jan 26, 2021
backend name of a processgroup created using distributed_c10d python API is tracked, but there is no good way to track name of a processgroup created using processGroup c++ API. In some cases, knowing backend name of a processGroup is useful, e,g., log the backend name, or write some codes that have dependency on the known backend. Differential Revision: [D26059769](https://our.internmc.facebook.com/intern/diff/D26059769/) ghstack-source-id: 120349147 Pull Request resolved: #51066
backend name of a processgroup created using distributed_c10d python API is tracked, but there is no good way to track name of a processgroup created using processGroup c++ API. In some cases, knowing backend name of a processGroup is useful, e,g., log the backend name, or write some codes that have dependency on the known backend. Differential Revision: [D26059769](https://our.internmc.facebook.com/intern/diff/D26059769/) [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Jan 26, 2021
Pull Request resolved: #51066 backend name of a processgroup created using distributed_c10d python API is tracked, but there is no good way to track name of a processgroup created using processGroup c++ API. In some cases, knowing backend name of a processGroup is useful, e,g., log the backend name, or write some codes that have dependency on the known backend. ghstack-source-id: 120398373 Differential Revision: [D26059769](https://our.internmc.facebook.com/intern/diff/D26059769/)
pritamdamania87
approved these changes
Jan 27, 2021
backend name of a processgroup created using distributed_c10d python API is tracked, but there is no good way to track name of a processgroup created using processGroup c++ API. In some cases, knowing backend name of a processGroup is useful, e,g., log the backend name, or write some codes that have dependency on the known backend. Differential Revision: [D26059769](https://our.internmc.facebook.com/intern/diff/D26059769/) [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Jan 28, 2021
Pull Request resolved: #51066 backend name of a processgroup created using distributed_c10d python API is tracked, but there is no good way to track name of a processgroup created using processGroup c++ API. In some cases, knowing backend name of a processGroup is useful, e,g., log the backend name, or write some codes that have dependency on the known backend. ghstack-source-id: 120543508 Differential Revision: [D26059769](https://our.internmc.facebook.com/intern/diff/D26059769/)
backend name of a processgroup created using distributed_c10d python API is tracked, but there is no good way to track name of a processgroup created using processGroup c++ API. In some cases, knowing backend name of a processGroup is useful, e,g., log the backend name, or write some codes that have dependency on the known backend. Differential Revision: [D26059769](https://our.internmc.facebook.com/intern/diff/D26059769/) [ghstack-poisoned]
backend name of a processgroup created using distributed_c10d python API is tracked, but there is no good way to track name of a processgroup created using processGroup c++ API. In some cases, knowing backend name of a processGroup is useful, e,g., log the backend name, or write some codes that have dependency on the known backend. Differential Revision: [D26059769](https://our.internmc.facebook.com/intern/diff/D26059769/) [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Jan 28, 2021
Pull Request resolved: #51066 backend name of a processgroup created using distributed_c10d python API is tracked, but there is no good way to track name of a processgroup created using processGroup c++ API. In some cases, knowing backend name of a processGroup is useful, e,g., log the backend name, or write some codes that have dependency on the known backend. ghstack-source-id: 120600598 Differential Revision: [D26059769](https://our.internmc.facebook.com/intern/diff/D26059769/)
backend name of a processgroup created using distributed_c10d python API is tracked, but there is no good way to track name of a processgroup created using processGroup c++ API. In some cases, knowing backend name of a processGroup is useful, e,g., log the backend name, or write some codes that have dependency on the known backend. Differential Revision: [D26059769](https://our.internmc.facebook.com/intern/diff/D26059769/) [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Jan 29, 2021
Pull Request resolved: #51066 backend name of a processgroup created using distributed_c10d python API is tracked, but there is no good way to track name of a processgroup created using processGroup c++ API. In some cases, knowing backend name of a processGroup is useful, e,g., log the backend name, or write some codes that have dependency on the known backend. ghstack-source-id: 120628432 Differential Revision: [D26059769](https://our.internmc.facebook.com/intern/diff/D26059769/)
This was referenced Jan 29, 2021
|
This pull request has been merged in d5541c5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
backend name of a processgroup created using distributed_c10d python API is tracked, but there is no good way to track name of a processgroup created using processGroup c++ API. In some cases, knowing backend name of a processGroup is useful, e,g., log the backend name, or write some codes that have dependency on the known backend.
Differential Revision: D26059769