Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gaussian NLL Loss #50886

Closed
wants to merge 1 commit into from
Closed

Add Gaussian NLL Loss #50886

wants to merge 1 commit into from

Conversation

nailimixaM
Copy link

Fixes #48520.

cc @albanD (This is a clean retry PR #49807)

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 21, 2021

💊 CI failures summary and remediations

As of commit 2204266 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

ci.pytorch.org: 2 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Could you just revert the tensorpipe submodule update please? (let me know if you want me to do it)

Will land when the submodule is fixed!

@nailimixaM
Copy link
Author

Looks great!
Could you just revert the tensorpipe submodule update please? (let me know if you want me to do it)

Will land when the submodule is fixed!

Done, fingers crossed this works!

@albanD
Copy link
Collaborator

albanD commented Jan 21, 2021

(rocm failures look unrelated)

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #50886 (2204266) into master (480bb7d) will increase coverage by 0.00%.
The diff coverage is 84.21%.

@@           Coverage Diff           @@
##           master   #50886   +/-   ##
=======================================
  Coverage   81.01%   81.01%           
=======================================
  Files        1916     1916           
  Lines      209285   209323   +38     
=======================================
+ Hits       169562   169593   +31     
- Misses      39723    39730    +7     

@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in 8eb90d4.

@almson
Copy link

almson commented Mar 13, 2021

Please see #53964

Main points:

  • reduction 'none' is not implemented the way it is elsewhere
  • nn.functional.gaussian_nll_loss is missing in the documentation
  • full parameter is useless and not theoretically grounded.
  • var should not be clamped in a no_grad context. gradients should be masked by the clamping.

@nailimixaM
Copy link
Author

@almson Thanks for your points. I've addressed these in #53964.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gaussian NLL loss
5 participants