New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gradient Compression] Refactor default_hooks.py and powerSGD_hook.py by creating a util function that make a vanilla allreduce future #51094
Conversation
… by creating a util function that make a vanilla allreduce future Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D26070147](https://our.internmc.facebook.com/intern/diff/D26070147/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 2ca21e5 (more details on the Dr. CI page):
🕵️ 9 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_linux_xenial_py3_clang5_asan_test2 (1/9)Step: "Run tests" (full log | diagnosis details | 🔁 rerun)
|
…SGD_hook.py by creating a util function that make a vanilla allreduce future" Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D26070147](https://our.internmc.facebook.com/intern/diff/D26070147/) [ghstack-poisoned]
… by creating a util function that make a vanilla allreduce future Pull Request resolved: #51094 Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 ghstack-source-id: 120376248 Differential Revision: [D26070147](https://our.internmc.facebook.com/intern/diff/D26070147/)
…SGD_hook.py by creating a util function that make a vanilla allreduce future" Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D26070147](https://our.internmc.facebook.com/intern/diff/D26070147/) [ghstack-poisoned]
…SGD_hook.py by creating a util function that make a vanilla allreduce future" Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D26070147](https://our.internmc.facebook.com/intern/diff/D26070147/) [ghstack-poisoned]
… by creating a util function that make a vanilla allreduce future Pull Request resolved: #51094 Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 ghstack-source-id: 120619680 Differential Revision: [D26070147](https://our.internmc.facebook.com/intern/diff/D26070147/)
This pull request has been merged in e7b3496. |
This pull request has been reverted by 5a406c0. |
Reverting due to a broken CI |
@SciPioneer Looks like the failures on this PR were legit:
|
…werSGD_hook.py by creating a util function that make a vanilla allreduce future Resubmission of #51094 Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D26162333](https://our.internmc.facebook.com/intern/diff/D26162333/) [ghstack-poisoned]
…s.py and powerSGD_hook.py by creating a util function that make a vanilla allreduce future" Resubmission of #51094 Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D26162333](https://our.internmc.facebook.com/intern/diff/D26162333/) [ghstack-poisoned]
…werSGD_hook.py by creating a util function that make a vanilla allreduce future Pull Request resolved: #51400 Resubmission of #51094 Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 ghstack-source-id: 120715333 Differential Revision: [D26162333](https://our.internmc.facebook.com/intern/diff/D26162333/)
…s.py and powerSGD_hook.py by creating a util function that make a vanilla allreduce future" Resubmission of #51094 Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D26162333](https://our.internmc.facebook.com/intern/diff/D26162333/) [ghstack-poisoned]
…werSGD_hook.py by creating a util function that make a vanilla allreduce future (#51400) Summary: Pull Request resolved: #51400 Resubmission of #51094 Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 ghstack-source-id: 120725690 Test Plan: buck test mode/dev-nosan caffe2/test/distributed:c10d -- test_powerSGD_ddp_comm_hook_nccl buck test mode/dev-nosan caffe2/test/distributed:c10d -- test_default_ddp_comm_hooks_nccl Reviewed By: rohan-varma Differential Revision: D26162333 fbshipit-source-id: ccc2eae5383a23673e00d61cb5570fb8bf749cd0
Stack from ghstack:
Address #50973 (comment)
Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202
Differential Revision: D26070147