-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resubmission][Gradient Compression] Refactor default_hooks.py and powerSGD_hook.py by creating a util function that make a vanilla allreduce future #51400
Conversation
…werSGD_hook.py by creating a util function that make a vanilla allreduce future Resubmission of #51094 Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D26162333](https://our.internmc.facebook.com/intern/diff/D26162333/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 95a8a14 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_python_doc_build (1/1)Step: "Doc Build and Push" (full log | diagnosis details | 🔁 rerun)
|
Job | Step | Action |
---|---|---|
pytorch_windows_vs2019_py36_cuda10.1_test1 | Unknown | 🔁 rerun |
Extra GitHub checks: 1 failed
- Failed: GitHub Actions -
clang-tidy
ci.pytorch.org: 1 failed
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
…s.py and powerSGD_hook.py by creating a util function that make a vanilla allreduce future" Resubmission of #51094 Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D26162333](https://our.internmc.facebook.com/intern/diff/D26162333/) [ghstack-poisoned]
…werSGD_hook.py by creating a util function that make a vanilla allreduce future Pull Request resolved: #51400 Resubmission of #51094 Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 ghstack-source-id: 120715333 Differential Revision: [D26162333](https://our.internmc.facebook.com/intern/diff/D26162333/)
Codecov Report
@@ Coverage Diff @@
## gh/SciPioneer/51/base #51400 +/- ##
=========================================================
- Coverage 80.86% 80.52% -0.34%
=========================================================
Files 1938 1938
Lines 211184 211182 -2
=========================================================
- Hits 170767 170061 -706
- Misses 40417 41121 +704 |
…s.py and powerSGD_hook.py by creating a util function that make a vanilla allreduce future" Resubmission of #51094 Address #50973 (comment) Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202 Differential Revision: [D26162333](https://our.internmc.facebook.com/intern/diff/D26162333/) [ghstack-poisoned]
This pull request has been merged in 0831984. |
Stack from ghstack:
Resubmission of #51094
Address #50973 (comment)
Original PR issue: Investigate Applying PowerSGD to Communication Hook for Gradient Compression #47202
Differential Revision: D26162333