-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Fix linalg.slogdet doc consistency issues #51300
[doc] Fix linalg.slogdet doc consistency issues #51300
Conversation
[ghstack-poisoned]
ghstack-source-id: 7e246bfe97602c32fb02499c95993ac584dabe8f Pull Request resolved: #51300
💊 CI failures summary and remediationsAs of commit 741041b (more details on the Dr. CI page):
🕵️ 3 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_linux_bionic_py3_6_clang9_test (1/3)Step: "Run tests" (full log | diagnosis details | 🔁 rerun)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple tweaks, otherwise looks great!
Codecov Report
@@ Coverage Diff @@
## gh/heitorschueroff/35/base #51300 +/- ##
==============================================================
- Coverage 80.85% 80.50% -0.35%
==============================================================
Files 1931 1931
Lines 210933 210933
==============================================================
- Hits 170546 169820 -726
- Misses 40387 41113 +726 |
This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287). Updated torch.linalg.slogdet to include notes about cross-device synchronization, backend routines used and fix signature missing out argument. [ghstack-poisoned]
Re-created from #51300 because of issues with ghstack. This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287). Updated torch.linalg.slogdet to include notes about cross-device synchronization, backend routines used and fix signature missing out argument. Differential Revision: [D26148678](https://our.internmc.facebook.com/intern/diff/D26148678) [ghstack-poisoned]
Summary: Pull Request resolved: #51353 Re-created from #51300 because of issues with ghstack. This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287). Updated torch.linalg.slogdet to include notes about cross-device synchronization, backend routines used and fix signature missing out argument. Test Plan: Imported from OSS Reviewed By: H-Huang Differential Revision: D26148678 Pulled By: heitorschueroff fbshipit-source-id: 40f6340226ecb72e4ec347c5606012f31f5877fb
This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).
Updated torch.linalg.slogdet to include notes about cross-device synchronization, backend routines used and fix signature missing out argument.
Stack from ghstack:
Differential Revision: D26147898