Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix linalg.slogdet doc consistency issues #51300

Closed

Conversation

heitorschueroff
Copy link
Contributor

@heitorschueroff heitorschueroff commented Jan 28, 2021

This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).

Updated torch.linalg.slogdet to include notes about cross-device synchronization, backend routines used and fix signature missing out argument.

Stack from ghstack:

Differential Revision: D26147898

heitorschueroff added a commit that referenced this pull request Jan 28, 2021
ghstack-source-id: 7e246bfe97602c32fb02499c95993ac584dabe8f
Pull Request resolved: #51300
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 28, 2021

💊 CI failures summary and remediations

As of commit 741041b (more details on the Dr. CI page):


  • 4/4 failures possibly* introduced in this PR
    • 1/4 non-CircleCI failure(s)

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_6_clang9_test (1/3)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jan 29 15:41:47 sccache: error: couldn't connect to server
Jan 29 15:41:47 +++ eval 'extract_trap_cmd '
Jan 29 15:41:47 ++++ extract_trap_cmd
Jan 29 15:41:47 ++++ printf '%s\n' ''
Jan 29 15:41:47 +++ printf '%s\n' cleanup
Jan 29 15:41:47 ++ trap -- '
Jan 29 15:41:47 cleanup' EXIT
Jan 29 15:41:47 ++ [[ pytorch-linux-bionic-py3.6-clang9-test != *pytorch-win-* ]]
Jan 29 15:41:47 ++ which sccache
Jan 29 15:41:47 ++ sccache --stop-server
Jan 29 15:41:47 Stopping sccache server...
Jan 29 15:41:47 sccache: error: couldn't connect to server
Jan 29 15:41:47 sccache: caused by: Connection refused (os error 111)
Jan 29 15:41:47 ++ true
Jan 29 15:41:47 ++ rm /var/lib/jenkins/sccache_error.log
Jan 29 15:41:47 ++ [[ pytorch-linux-bionic-py3.6-clang9-test == *rocm* ]]
Jan 29 15:41:47 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Jan 29 15:41:47 ++ SCCACHE_IDLE_TIMEOUT=1200
Jan 29 15:41:47 ++ RUST_LOG=sccache::server=error
Jan 29 15:41:47 ++ sccache --start-server
Jan 29 15:41:47 sccache: Starting the server...
Jan 29 15:41:47 ++ sccache --zero-stats

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test1 (2/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

RuntimeError: distributed/test_c10d failed!
  File "C:\Users\circleci\project\build\win_tmp\build\torch\distributed\algorithms\ddp_comm_hooks\__init__.py", line 7, in <module>
    from . import (
  File "C:\Users\circleci\project\build\win_tmp\build\torch\distributed\algorithms\ddp_comm_hooks\powerSGD_hook.py", line 7, in <module>
    import torch.distributed.algorithms.ddp_comm_hooks.default_hooks as default
AttributeError: module 'torch.distributed.algorithms' has no attribute 'ddp_comm_hooks'
Traceback (most recent call last):
  File "run_test.py", line 925, in <module>
    main()
  File "run_test.py", line 904, in main
    raise RuntimeError(err_message)
RuntimeError: distributed/test_c10d failed!

(base) C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1 
+ cleanup
+ retcode=1
+ set +x


Exited with code exit status 1

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (3/3)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jan 29 15:45:07 sccache: error: couldn't connect to server
Jan 29 15:45:07 +++ eval 'extract_trap_cmd '
Jan 29 15:45:07 ++++ extract_trap_cmd
Jan 29 15:45:07 ++++ printf '%s\n' ''
Jan 29 15:45:07 +++ printf '%s\n' cleanup
Jan 29 15:45:07 ++ trap -- '
Jan 29 15:45:07 cleanup' EXIT
Jan 29 15:45:07 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-test != *pytorch-win-* ]]
Jan 29 15:45:07 ++ which sccache
Jan 29 15:45:07 ++ sccache --stop-server
Jan 29 15:45:07 Stopping sccache server...
Jan 29 15:45:07 sccache: error: couldn't connect to server
Jan 29 15:45:07 sccache: caused by: Connection refused (os error 111)
Jan 29 15:45:07 ++ true
Jan 29 15:45:07 ++ rm /var/lib/jenkins/sccache_error.log
Jan 29 15:45:07 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-test == *rocm* ]]
Jan 29 15:45:07 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Jan 29 15:45:07 ++ SCCACHE_IDLE_TIMEOUT=1200
Jan 29 15:45:07 ++ RUST_LOG=sccache::server=error
Jan 29 15:45:07 ++ sccache --start-server
Jan 29 15:45:07 sccache: Starting the server...
Jan 29 15:45:07 ++ sccache --zero-stats

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

torch/linalg/__init__.py Outdated Show resolved Hide resolved
torch/linalg/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple tweaks, otherwise looks great!

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #51300 (3c29129) into gh/heitorschueroff/35/base (33d5180) will decrease coverage by 0.34%.
The diff coverage is n/a.

@@                      Coverage Diff                       @@
##           gh/heitorschueroff/35/base   #51300      +/-   ##
==============================================================
- Coverage                       80.85%   80.50%   -0.35%     
==============================================================
  Files                            1931     1931              
  Lines                          210933   210933              
==============================================================
- Hits                           170546   169820     -726     
- Misses                          40387    41113     +726     

This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).

Updated torch.linalg.slogdet to include notes about cross-device synchronization, backend routines used and fix signature missing out argument.




[ghstack-poisoned]
heitorschueroff added a commit that referenced this pull request Feb 1, 2021
Re-created from #51300 because of issues with ghstack.

This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).

Updated torch.linalg.slogdet to include notes about cross-device synchronization, backend routines used and fix signature missing out argument.


Differential Revision: [D26148678](https://our.internmc.facebook.com/intern/diff/D26148678)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Feb 2, 2021
Summary:
Pull Request resolved: #51353

Re-created from #51300 because of issues with ghstack.

This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).

Updated torch.linalg.slogdet to include notes about cross-device synchronization, backend routines used and fix signature missing out argument.

Test Plan: Imported from OSS

Reviewed By: H-Huang

Differential Revision: D26148678

Pulled By: heitorschueroff

fbshipit-source-id: 40f6340226ecb72e4ec347c5606012f31f5877fb
@facebook-github-bot facebook-github-bot deleted the gh/heitorschueroff/35/head branch March 1, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants