New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Fix linalg.slogdet doc consistency issues #51353
Closed
heitorschueroff
wants to merge
2
commits into
gh/heitorschueroff/37/base
from
gh/heitorschueroff/37/head
Closed
[doc] Fix linalg.slogdet doc consistency issues #51353
heitorschueroff
wants to merge
2
commits into
gh/heitorschueroff/37/base
from
gh/heitorschueroff/37/head
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit f3c1328 (more details on the Dr. CI page):
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm: pytorch_xla_linux_bionic_py3_6_clang9_test (1/1)Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️
|
mruberry
approved these changes
Jan 29, 2021
Re-created from #51300 because of issues with ghstack. This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287). Updated torch.linalg.slogdet to include notes about cross-device synchronization, backend routines used and fix signature missing out argument. Differential Revision: [D26148678](https://our.internmc.facebook.com/intern/diff/D26148678) [ghstack-poisoned]
@heitorschueroff merged this pull request in 1caed16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-created from #51300 because of issues with ghstack.
This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).
Updated torch.linalg.slogdet to include notes about cross-device synchronization, backend routines used and fix signature missing out argument.
Stack from ghstack:
Differential Revision: D26148678