Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix linalg.slogdet doc consistency issues #51353

Closed

Conversation

heitorschueroff
Copy link
Contributor

@heitorschueroff heitorschueroff commented Jan 29, 2021

Re-created from #51300 because of issues with ghstack.

This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).

Updated torch.linalg.slogdet to include notes about cross-device synchronization, backend routines used and fix signature missing out argument.

Stack from ghstack:

Differential Revision: D26148678

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 29, 2021

💊 CI failures summary and remediations

As of commit f3c1328 (more details on the Dr. CI page):



❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Feb 01 16:38:51 RuntimeError: tensorflow/compiler/xla/xla_client/xrt_local_service.cc:56 : Check failed: tensorflow::NewServer(server_def, &server_) == ::tensorflow::Status::OK() (Unknown: Could not start gRPC server vs. OK)
Feb 01 16:38:51   File "/opt/conda/lib/python3.6/site-packages/torch_xla-1.6-py3.6-linux-x86_64.egg/torch_xla/distributed/xla_multiprocessing.py", line 314, in _setup_replication
Feb 01 16:38:51     device = xm.xla_device()
Feb 01 16:38:51   File "/opt/conda/lib/python3.6/site-packages/torch_xla-1.6-py3.6-linux-x86_64.egg/torch_xla/core/xla_model.py", line 231, in xla_device
Feb 01 16:38:51     devkind=devkind if devkind is not None else None)
Feb 01 16:38:51   File "/opt/conda/lib/python3.6/site-packages/torch_xla-1.6-py3.6-linux-x86_64.egg/torch_xla/core/xla_model.py", line 136, in get_xla_supported_devices
Feb 01 16:38:51     xla_devices = _DEVICES.value
Feb 01 16:38:51   File "/opt/conda/lib/python3.6/site-packages/torch_xla-1.6-py3.6-linux-x86_64.egg/torch_xla/utils/utils.py", line 32, in value
Feb 01 16:38:51     self._value = self._gen_fn()
Feb 01 16:38:51   File "/opt/conda/lib/python3.6/site-packages/torch_xla-1.6-py3.6-linux-x86_64.egg/torch_xla/core/xla_model.py", line 18, in <lambda>
Feb 01 16:38:51     _DEVICES = xu.LazyProperty(lambda: torch_xla._XLAC._xla_get_devices())
Feb 01 16:38:51 RuntimeError: tensorflow/compiler/xla/xla_client/xrt_local_service.cc:56 : Check failed: tensorflow::NewServer(server_def, &server_) == ::tensorflow::Status::OK() (Unknown: Could not start gRPC server vs. OK)
Feb 01 16:38:51 Traceback (most recent call last):
Feb 01 16:38:51   File "/var/lib/jenkins/workspace/xla/test/test_mp_distributed_mm.py", line 43, in <module>
Feb 01 16:38:51     xmp.spawn(_mp_fn, nprocs=None)
Feb 01 16:38:51   File "/opt/conda/lib/python3.6/site-packages/torch_xla-1.6-py3.6-linux-x86_64.egg/torch_xla/distributed/xla_multiprocessing.py", line 394, in spawn
Feb 01 16:38:51     start_method=start_method)
Feb 01 16:38:51   File "/opt/conda/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 188, in start_processes
Feb 01 16:38:51     while not context.join():
Feb 01 16:38:51   File "/opt/conda/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 144, in join
Feb 01 16:38:51     exit_code=exitcode
Feb 01 16:38:51 torch.multiprocessing.spawn.ProcessExitedException: process 3 terminated with exit code 17

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Re-created from #51300 because of issues with ghstack.

This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).

Updated torch.linalg.slogdet to include notes about cross-device synchronization, backend routines used and fix signature missing out argument.


Differential Revision: [D26148678](https://our.internmc.facebook.com/intern/diff/D26148678)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@heitorschueroff merged this pull request in 1caed16.

@facebook-github-bot facebook-github-bot deleted the gh/heitorschueroff/37/head branch February 6, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants