Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix linalg.cholesky doc consistency issues #51459

Closed

Conversation

heitorschueroff
Copy link
Contributor

@heitorschueroff heitorschueroff commented Feb 1, 2021

This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).

Stack from ghstack:

Differential Revision: D26176131

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 1, 2021

💊 CI failures summary and remediations

As of commit 126825d (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).


Differential Revision: [D26176131](https://our.internmc.facebook.com/intern/diff/D26176131)

[ghstack-poisoned]
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #51459 (126825d) into gh/heitorschueroff/39/base (449098c) will decrease coverage by 0.34%.
The diff coverage is n/a.

@@                      Coverage Diff                       @@
##           gh/heitorschueroff/39/base   #51459      +/-   ##
==============================================================
- Coverage                       80.86%   80.51%   -0.35%     
==============================================================
  Files                            1938     1938              
  Lines                          211273   211273              
==============================================================
- Hits                           170838   170115     -723     
- Misses                          40435    41158     +723     

facebook-github-bot pushed a commit that referenced this pull request Feb 1, 2021
)

Summary:
Pull Request resolved: #51460

This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).

* #51459 [doc] Fix linalg.cholesky doc consistency issues

Test Plan: Imported from OSS

Reviewed By: mruberry

Differential Revision: D26176130

Pulled By: heitorschueroff

fbshipit-source-id: cc89575db69cbfd5f87d970a2e71deb6522a35b1
@facebook-github-bot
Copy link
Contributor

@heitorschueroff merged this pull request in 8583f7c.

@facebook-github-bot facebook-github-bot deleted the gh/heitorschueroff/39/head branch February 5, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants