Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Deprecate torch.cholesky in favor of torch.linalg.cholesky #51460

Closed

Conversation

heitorschueroff
Copy link
Contributor

@heitorschueroff heitorschueroff commented Feb 1, 2021

This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).

Stack from ghstack:

Differential Revision: D26176130

heitorschueroff added a commit that referenced this pull request Feb 1, 2021
ghstack-source-id: aa343d741c0114a4e38448d3d215080bc3825f71
Pull Request resolved: #51460
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 1, 2021

💊 CI failures summary and remediations

As of commit 75403f7 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

torch/_torch_docs.py Outdated Show resolved Hide resolved
…olesky"

This PR is part of a larger effort to ensure torch.linalg documentation is consistent (see #50287).


Differential Revision: [D26176130](https://our.internmc.facebook.com/intern/diff/D26176130)

[ghstack-poisoned]
heitorschueroff added a commit that referenced this pull request Feb 1, 2021
instead.

ghstack-source-id: 304b578c1e8f842912ccdffa291eac03e3677fad
Pull Request resolved: #51460
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #51460 (75403f7) into gh/heitorschueroff/40/base (126825d) will increase coverage by 19.52%.
The diff coverage is n/a.

@@                       Coverage Diff                       @@
##           gh/heitorschueroff/40/base   #51460       +/-   ##
===============================================================
+ Coverage                       61.32%   80.85%   +19.52%     
===============================================================
  Files                            1783     1938      +155     
  Lines                          179508   211273    +31765     
===============================================================
+ Hits                           110086   170825    +60739     
+ Misses                          69422    40448    -28974     

@facebook-github-bot
Copy link
Contributor

@heitorschueroff merged this pull request in 8fa328f.

@facebook-github-bot facebook-github-bot deleted the gh/heitorschueroff/40/head branch February 5, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants