Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Union[T, NoneType] as Optional[T] #51605

Closed

Conversation

nikithamalgifb
Copy link
Contributor

@nikithamalgifb nikithamalgifb commented Feb 3, 2021

Stack from ghstack:

nikithamalgifb pushed a commit that referenced this pull request Feb 3, 2021
ghstack-source-id: 32db9661ce0f9441ef7061285bc24967c2808ea6
Pull Request resolved: #51605
@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Feb 3, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 3, 2021

💊 CI failures summary and remediations

As of commit 1380edb (more details on the Dr. CI page):


  • 2/6 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)
  • 4/6 broken upstream at merge base b283ac6 on Feb 02 from 3:39pm to 7:49pm

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 Run tests 🔁 rerun

🚧 4 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

nikithamalgifb pushed a commit that referenced this pull request Feb 3, 2021
ghstack-source-id: 6cde5155c57cde7645c230b7fce2e37b2d1ddd85
Pull Request resolved: #51605
@facebook-github-bot
Copy link
Contributor

@nikithamalgifb merged this pull request in ecf8166.

@facebook-github-bot facebook-github-bot deleted the gh/nikithamalgifb/4/head branch February 7, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants