Support Union[NoneType, T] as input type #51606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
cla signed
oncall: jit
💊 CI failures summary and remediationsAs of commit 7226a54 (more details on the Dr. CI page):
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 |
Run tests | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
ghstack-source-id: 6cde5155c57cde7645c230b7fce2e37b2d1ddd85 Pull Request resolved: #51605
nikithamalgifb
force-pushed
the
gh/nikithamalgifb/4/orig
branch
from
808315a
to
7226a54
Compare
gmagogsfm
approved these changes
Feb 3, 2021
| } else if (!first_none && second_none) { | ||
| return OptionalType::create(first_type); | ||
| } else { | ||
| throw ErrorReport(subscript.range()) << err; |
There was a problem hiding this comment.
Just to be clear, Union[None, None] would trigger this line and error out, is this intended?
There was a problem hiding this comment.
Yes. That should be handled during the regular Union.
| return u | ||
| else: | ||
| return 0 | ||
| scripted = torch.jit.script(test1) |
There was a problem hiding this comment.
Optional:
Use self.checkScript
There was a problem hiding this comment.
I was told self.checkScript is the old way in one of my earlier PR's.
There was a problem hiding this comment.
Hmm, didn't know about that. What's wrong with it and what's the alternative?
There was a problem hiding this comment.
@nikithamalgifb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@nikithamalgifb merged this pull request in ecf8166. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghstack-source-id: 32db9661ce0f9441ef7061285bc24967c2808ea6
Pull Request resolved: #51605
Fixes #51582
Summary:
In Python 3.9+ Union[T, NoneType] and Union[NoneType, T] as OptionalType.
Test:
python test/test_jit.py -v TestJit.test_union_to_optional