Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix inconsistencies with linalg.pinv docs and deprecate pinverse #51671

Closed

Conversation

heitorschueroff
Copy link
Contributor

@heitorschueroff heitorschueroff commented Feb 3, 2021

Stack from ghstack:

Differential Revision: D26240534

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 3, 2021

💊 CI failures summary and remediations

As of commit cb318c1 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #51671 (cb318c1) into gh/heitorschueroff/46/base (b05e431) will increase coverage by 0.51%.
The diff coverage is 100.00%.

@@                      Coverage Diff                       @@
##           gh/heitorschueroff/46/base   #51671      +/-   ##
==============================================================
+ Coverage                       80.39%   80.91%   +0.51%     
==============================================================
  Files                            1948     1948              
  Lines                          212371   212371              
==============================================================
+ Hits                           170741   171838    +1097     
+ Misses                          41630    40533    -1097     

@facebook-github-bot
Copy link
Contributor

@heitorschueroff merged this pull request in ff4848a.

@facebook-github-bot facebook-github-bot deleted the gh/heitorschueroff/46/head branch February 8, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants