Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix inconsistencies with torch.linalg.inv and deprecate torch.inverse #51672

Closed

Conversation

heitorschueroff
Copy link
Contributor

@heitorschueroff heitorschueroff commented Feb 3, 2021

Stack from ghstack:

Differential Revision: D26240535

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 3, 2021

💊 CI failures summary and remediations

As of commit a0c4f8c (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

heitorschueroff added a commit that referenced this pull request Feb 4, 2021
…nverse

ghstack-source-id: 767eb379e7fe6f87c4ac10121c88bdf3169d78c5
Pull Request resolved: #51672
heitorschueroff added a commit that referenced this pull request Feb 4, 2021
…nverse

ghstack-source-id: 00461a4c0965cd5ac56ad30f6100095c883e34de
Pull Request resolved: #51672
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

heitorschueroff added a commit that referenced this pull request Feb 4, 2021
…nverse

ghstack-source-id: b0c88a7225a12f949ad44b2f7e143c417350ff1c
Pull Request resolved: #51672
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #51672 (a0c4f8c) into gh/heitorschueroff/47/base (cb318c1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@                      Coverage Diff                       @@
##           gh/heitorschueroff/47/base   #51672      +/-   ##
==============================================================
- Coverage                       80.91%   80.91%   -0.01%     
==============================================================
  Files                            1948     1948              
  Lines                          212371   212371              
==============================================================
- Hits                           171838   171835       -3     
- Misses                          40533    40536       +3     

@facebook-github-bot
Copy link
Contributor

@heitorschueroff merged this pull request in e7ff085.

@facebook-github-bot facebook-github-bot deleted the gh/heitorschueroff/47/head branch February 8, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants