[numpy] torch.{rad2deg, deg2rad}: promote integer inputs to float #51853
+28
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 1b2f573 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
1 task
Codecov Report
@@ Coverage Diff @@
## master #51853 +/- ##
==========================================
- Coverage 80.77% 80.76% -0.01%
==========================================
Files 1969 1969
Lines 216063 216076 +13
==========================================
+ Hits 174515 174517 +2
- Misses 41548 41559 +11 |
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Like #51956, would you rebase this and I'll work on getting it landed? Sorry about the break due to PTO. |
…lop/numpy/unary-float-op/rad2deg-deg2rad
|
No worries. Thanks for looking into it. :) |
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
…torch#51853) Summary: Reference: pytorch#42515 Depends on pytorch#51283 Pull Request resolved: pytorch#51853 Reviewed By: albanD Differential Revision: D26399743 Pulled By: mruberry fbshipit-source-id: a6f0e12723e1451c6479d818752fe5d41788715d
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
…torch#51853) Summary: Reference: pytorch#42515 Depends on pytorch#51283 Pull Request resolved: pytorch#51853 Reviewed By: albanD Differential Revision: D26399743 Pulled By: mruberry fbshipit-source-id: a6f0e12723e1451c6479d818752fe5d41788715d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #42515
Depends on #51283