[1.8] Workaround arm64 gcc error in std::copysign (#51900)
#52049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Move definition of copysign template and specialization for bfloat16/half types before first use of copysign in that file Add comment explaining why this is necessary Fixes pytorch#51889 Pull Request resolved: pytorch#51900 Reviewed By: walterddr Differential Revision: D26321741 Pulled By: malfet fbshipit-source-id: 888858b11d9708fa140fe9c0570cc5a24599205b
Codecov Report
@@ Coverage Diff @@
## release/1.8 #52049 +/- ##
===============================================
+ Coverage 80.48% 80.82% +0.33%
===============================================
Files 1948 1948
Lines 213176 213176
===============================================
+ Hits 171584 172295 +711
+ Misses 41592 40881 -711 |
walterddr
approved these changes
Feb 12, 2021
💊 CI failures summary and remediationsAs of commit 4201e12 (more details on the Dr. CI page): Commit 4201e12 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move definition of copysign template and specialization for
bfloat16/half types before first use of copysign in that file
Add comment explaining why this is necessary
Fixes #51889
This is a cherry-pick of #51900 into release/1.8 branch
Reviewed By: walterddr