Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v.1.8.0] Release Tracker #51886

Closed
seemethere opened this issue Feb 8, 2021 · 38 comments
Closed

[v.1.8.0] Release Tracker #51886

seemethere opened this issue Feb 8, 2021 · 38 comments
Labels
oncall: releng In support of CI and Release Engineering triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
1.8.0

Comments

@seemethere
Copy link
Member

seemethere commented Feb 8, 2021 •
edited
Loading

We cut a release branch for the 1.8.0 release.

Our plan from this point from this point is roughly:

  • Phase 1 (until 2/18): work on finalizing the release branch
  • Phase 2 (after 2/18): perform extended integration/stability/performance testing based on Release Candidate builds.

This issue is for tracking cherry-picks to the release branch.

Cherry-Pick Criteria

Phase 1 (until 2/18/21):

Only low-risk changes may be cherry-picked from master:

  1. Fixes to regressions against the most recent minor release (e.g. 1.8.0 for 1.8.x release; see topic: regression issue list)
  2. Critical fixes for: silent correctness, crashes, deadlocks, (large) memory leaks.
  3. Fixes to new features introduced in the most recent minor release (e.g. 1.8.0 for 1.8.x release)
  4. Test/CI fixes
  5. Documentation improvements
  6. Release branch specific changes (e.g. change version identifiers)

Any other change requires special dispensation from the release managers (currently @malfet, @seemethere, @gchanan). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.

Phase 2 (after 2/18/21):

Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are:

Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks

This will likely require a discussion with the larger release team over VC or Slack.

Cherry-Pick Process

  1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).
  2. Create (but do not land) a PR against the release branch.
  3. Make a request below with the following format:
Link to landed master PR (if applicable):
Link to release branch PR:
Criteria Category:`
  1. Someone from the release team will reply with approved / denied or ask for more information.
  2. If approved, someone from the release team will merge your PR once the tests pass. NOTE: do not land the release branch PR yourself. Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.
@seemethere seemethere added oncall: releng In support of CI and Release Engineering triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Feb 8, 2021
@seemethere seemethere added this to the 1.8.0 milestone Feb 8, 2021
@seemethere seemethere pinned this issue Feb 8, 2021
@walterddr
Copy link
Contributor

walterddr commented Feb 8, 2021 •
edited by seemethere
Loading

Link to landed master PR (if applicable): #51634, 9cbefad
Link to release branch PR: #51882
Criteria Category: Critical fixes (License)

@seemethere: Merged

@janeyx99
Copy link
Contributor

janeyx99 commented Feb 8, 2021 •
edited by seemethere
Loading

Link to landed master PR (if applicable): #51864, fcf8b71
Link to release branch PR: #51890
Criteria Category: Test/CI fixes

@seemethere: Merged

@ppwwyyxx
Copy link
Contributor

ppwwyyxx commented Feb 8, 2021 •
edited by seemethere
Loading

Link to landed master PR: #51789
Link to release branch PR: #51913
Criteria Category: Fix to new features introduced in 1.8.
It's a small change that fixed a small typing issue in ternary op of JIT #49165.

@seemethere: Merged

@jamesr66a
Copy link
Collaborator

jamesr66a commented Feb 9, 2021 •
edited by seemethere
Loading

Link to release branch PR: #51987
Criteria category: Release branch specific changes

@seemethere: Merged

@seemethere
Copy link
Member Author

seemethere commented Feb 9, 2021 •
edited
Loading

Link to release branch PR: #51982
Criteria category: Release branch specific changes

@seemethere: Merged

@seemethere
Copy link
Member Author

seemethere commented Feb 9, 2021 •
edited
Loading

Link to landed master PR (if applicable): #51825
Link to release branch PR: #52006
Criteria Category: Test/CI fixes

@seemethere: Merged

@jamesr66a jamesr66a reopened this Feb 10, 2021
@jamesr66a
Copy link
Collaborator

jamesr66a commented Feb 10, 2021 •
edited by malfet
Loading

Link to landed master PR (if applicable): #51998 #52010 #51927
Link to release branch PR: #52021
Criteria Category: Fixes to new features introduced in the most recent minor release

@malfet: merged

@malfet
Copy link
Contributor

malfet commented Feb 10, 2021 •
edited
Loading

Link to landed master PR: #51900
Link to release branch PR: #52049
Criteria Category: Fixes regression from previous release

@malfet: merged

@malfet
Copy link
Contributor

malfet commented Feb 10, 2021 •
edited by seemethere
Loading

Link to landed master PR: #51806
Link to release branch PR: #52050
Criteria Category: Bugfix targeted for 1.8

@seemethere: Merged

@vkuzo
Copy link
Contributor

vkuzo commented Feb 11, 2021 •
edited by malfet
Loading

Link to landed master PR (if applicable): #51878
Link to release branch PR: #52160
Criteria Category: Documentation improvements (hiding a function without docs)

@malfet: merged

@wayi1
Copy link
Contributor

wayi1 commented Feb 12, 2021 •
edited by seemethere
Loading

Link to landed master PR: #51773, #51846, #51986
Link to release branch PR: #52215
Criteria Category: Documentation improvements (created a tutorial page and then some minor updates on this page)

@seemethere: Merged

@mruberry
Copy link
Collaborator

mruberry commented Feb 13, 2021 •
edited by malfet
Loading

Link to landed master PR: #52202
Link to release branch PR: #52242
Criteria Category: Documentation improvements (removing an option from a new kwarg to prevent its being used)

@malfet: merged

@rohan-varma
Copy link
Member

rohan-varma commented Feb 15, 2021 •
edited by malfet
Loading

Link to landed master PR: #50180
Link to release branch PR: #52270
Criteria Category: Fixes to regressions against the most recent minor release (fixes perf regrssion in DDP by adding back side stream capability.)

@malfet: merged

@VitalyFedyunin
Copy link
Contributor

VitalyFedyunin commented Feb 16, 2021 •
edited by malfet
Loading

Link to landed master PR: #52327
Link to release branch PR: #52313
Criteria Category: Fixes OneDNN bug for specific tensor shapes

@malfet: merged

@malfet
Copy link
Contributor

malfet commented Feb 17, 2021 •
edited by seemethere
Loading

Link to landed maser PRs: #52184, #52183 and #52182
Link to release branch PR: #52365
Criteria Category: Regression from previous release

@seemethere: Merged

@eellison
Copy link
Contributor

eellison commented Feb 17, 2021 •
edited by malfet
Loading

Link to landed master PR: #52337
Link to release branch PR: #52392
Criteria category: Fixes to new features introduced in the most recent minor release / Documentation fix

@malfet: merge

@zou3519
Copy link
Contributor

zou3519 commented Feb 17, 2021 •
edited by malfet
Loading

Link to landed master PR (if applicable): n/a, release-specific change
Link to release branch PR: #52397
Criteria Category: Release branch specific changes: remove/hide prototype feature that isn't ready for release

@malfet: merged

@zou3519 zou3519 mentioned this issue Feb 17, 2021
Closed
@malfet
Copy link
Contributor

malfet commented Feb 18, 2021 •
edited
Loading

Link to landed master PR: #52243
Link to release branch PR: #52404
Criteria Category: Build system fix

@malfet: merged

@seemethere
Copy link
Member Author

seemethere commented Feb 18, 2021 •
edited
Loading

Link to landed master PR: #52151
Link to release branch PR: #52406
Criteria Category: Special Dispensation, CUDA 11.2 is not as performant as we had thought

@seemethere: Merged

@SplitInfinity
Copy link

SplitInfinity commented Feb 18, 2021 •
edited by malfet
Loading

Link to landed master PR (if applicable): #42835
Link to release branch PR: #52430
Criteria Category: Need to enable QAT for TensorRT

@malfet: merged

@gchanan
Copy link
Contributor

gchanan commented Feb 18, 2021 •
edited by malfet
Loading

Link to landed master PR (if applicable): #52389
Link to release branch PR: #52445
Criteria Category: Critical fixes for: silent correctness

@malfet: merged

@albanD
Copy link
Collaborator

albanD commented Feb 18, 2021 •
edited by malfet
Loading

Link to landed master PR (if applicable): #52311
Link to release branch PR: #52446
Criteria Category: Critical doc fix for symeig backward

@malfet: merged

@janeyx99
Copy link
Contributor

janeyx99 commented Feb 18, 2021 •
edited by malfet
Loading

Link to landed master PR (if applicable): #52443
Link to release branch PR: #52469
Criteria Category: Tests/CI fixes

@malfet: merged

@BowenBao
Copy link
Collaborator

BowenBao commented Feb 19, 2021 •
edited by seemethere
Loading

Link to landed master PR (if applicable): #52349, #52350
Link to release branch PR: #52510
Criteria Category: Critical fixes for: onnx mixed precision export

@seemethere: Merged

@seemethere
Copy link
Member Author

seemethere commented Feb 19, 2021 •
edited
Loading

Link to landed master PR (if applicable): #52509, #52503, #52305
Link to release branch PR: #52518
Criteria Category: Criteria Category: Special Dispensation, Needed to enable #51886 (comment)

@seemethere: Merged

@malfet
Copy link
Contributor

malfet commented Feb 22, 2021 •
edited by seemethere
Loading

Link to landed master PR: #51847
Link to release branch PR: #52601
Criteria Category: Documentation update

@seemethere: Merged

@lw
Copy link
Contributor

lw commented Feb 22, 2021 •
edited by seemethere
Loading

Not sure if we're still in time, but there's a fix in the TensorPipe submodule which may make sense to cherry-pick. It can cause a crash of RPC at init in some configurations, although there is an undocumented workaround.

Link to landed master PR: N/A
Link to release branch PR: #52615

@seemethere: merged

@malfet
Copy link
Contributor

malfet commented Feb 23, 2021 •
edited
Loading

Link to landed master PR: N/A (sort of #52645 )
Link to release branch PR: #52647
Criteria Category: Fixes crash caused by XNNPACK update

@malfet: merged

@xwang233
Copy link
Collaborator

xwang233 commented Feb 23, 2021 •
edited by malfet
Loading

Link to landed master PR (if applicable): #52351
Link to release branch PR: #52649
Criteria Category: Fix regression compared to 1.7 release

@malfet: merged

@lw
Copy link
Contributor

lw commented Feb 23, 2021 •
edited by malfet
Loading

Link to landed master PR: N/A
Link to release branch PR: #52682

Disables the CUDA support from the C++ parts of TensorPipe and its RPC agent, since that's a prototype feature and shouldn't be part of the 1.8 binaries.

@malfet: Tentatively targeting for 1.8.1

@mrshenli
Copy link
Contributor

mrshenli commented Feb 23, 2021 •
edited by malfet
Loading

Link to landed master PR: N/A
Link to release branch PR: #52683

Hide prototype CUDA RPC APIs

@malfet: Will not pick the change into release branch unless we have to make another RC

@droberts195 droberts195 mentioned this issue Feb 24, 2021
Merged
@zasdfgbnm
Copy link
Collaborator

zasdfgbnm commented Feb 24, 2021 •
edited by malfet
Loading

Link to landed master PR (if applicable): #52713 (WIP)
Link to release branch PR: WIP
Criteria Category: crash

@malfet: Will not pick at this point, since this is not a regression

@jeffdaily
Copy link
Collaborator

jeffdaily commented Feb 24, 2021 •
edited by seemethere
Loading

Link to landed master PR:

Link to release branch PR: #52756 (above PRs cherry-picked into one PR)

Criteria Category: Regression in building ROCm pytorch extension modules

Low risk. Only affects ROCm builds. Would prevent publishing ROCm PyTorch wheels if unable to then build torchvision.

@seemethere: Merged

@walterddr
Copy link
Contributor

walterddr commented Feb 25, 2021 •
edited by malfet
Loading

Link to landed master PR (if applicable): #52750
Link to release branch PR: #52801
Criteria Category: File execute permission

@malfet: Merged as it does not change contents of any files in the package.

@lw
Copy link
Contributor

lw commented Feb 25, 2021

Queueing this up for v1.8.1 (or earlier in case another RC is cut).

Link to landed master PR: #52677
Link to release branch PR: #52854

@neerajprad
Copy link
Contributor

neerajprad commented Feb 26, 2021 •
edited by malfet
Loading

Link to landed master PR (if applicable): #52763
Link to release branch PR: #52904
Criteria Category: Documentation improvements (missing class added to distributions.rst file)

@malfet: Merged, as it changes only documentation.

@jerryzh168
Copy link
Contributor

jerryzh168 commented Mar 1, 2021 •
edited by seemethere
Loading

Please merge: #53055, this removes some docs from release branch since the feature is a prototype feature.

@seemethere: Merged

@pytorch pytorch locked as resolved and limited conversation to collaborators Mar 4, 2021
@seemethere
Copy link
Member Author

seemethere commented Mar 4, 2021 •
edited
Loading

Hey everyone! The 1.8.0 release is officially out so going to go ahead and close / lock this.

Thank you to everyone who helped make this release happen 🥂

@seemethere seemethere unpinned this issue Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
oncall: releng In support of CI and Release Engineering triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests