Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend DynamcLibrary constructor to support alternative library name #52183

Closed
wants to merge 1 commit into from
Closed

Extend DynamcLibrary constructor to support alternative library name #52183

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Feb 12, 2021 •
edited
Loading

Stack from ghstack:

Differential Revision: D26417405

This was referenced Feb 12, 2021
Closed
Closed
@malfet malfet requested a review from a team February 12, 2021 02:15
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 12, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 4defa86 (more details on the Dr. CI page):

  • 2/3 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)
  • 1/3 broken upstream at merge base 2568861 since Feb 11

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test1 (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

AssertionError: True is not false 
======================================================================
FAIL [52.861s]: test_fd_sharing (__main__.TestMultiprocessing)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_multiprocessing.py", line 327, in test_fd_sharing
    self._test_sharing(repeat=TEST_REPEATS)
  File "test_multiprocessing.py", line 282, in _test_sharing
    test_fill()
  File "test_multiprocessing.py", line 260, in test_fill
    self.assertFalse(p.is_alive())
AssertionError: True is not false

----------------------------------------------------------------------
Ran 36 tests in 205.507s

FAILED (failures=1, skipped=17)

Generating XML reports...
Generated XML report: test-reports\python-unittest\TEST-TestMultiprocessing-20210212030734.xml
Traceback (most recent call last):
  File "run_test.py", line 925, in <module>

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet.

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in 357e5ba.

@facebook-github-bot facebook-github-bot deleted the gh/malfet/2/head branch February 17, 2021 15:16
malfet added a commit to malfet/pytorch that referenced this pull request Feb 17, 2021
@malfet
Extend DynamcLibrary constructor to support alternative library name (p…
d91e6f5 
…ytorch#52183)

Summary:
Pull Request resolved: pytorch#52183

This allows one to load library that can exist on the system under different names.
Currently, this functionality is Linux only, as on Windows shared libraries are not renamed by `auditwheel`

Test Plan: Imported from OSS

Reviewed By: walterddr

Differential Revision: D26417405

Pulled By: malfet

fbshipit-source-id: d327e2565b26cf5b7214e7978862f56e02cad7c6
This was referenced Feb 17, 2021
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterddr walterddr walterddr approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@malfet @facebook-github-bot @walterddr