[PyTorch] Make c10::str(const char*) return const char* #52222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`c10::str()` is often used with variadic macros. It can be more efficient to get a C string out if you put a C string in, like if you are able to defer std::string creation to an outlined function or even never do it at all. Meanwhile, there is an implicit conversion from const char* to std::string, so users who expected a std::string will still make one. Differential Revision: [D26419663](https://our.internmc.facebook.com/intern/diff/D26419663/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit fc6714d (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This was referenced Feb 12, 2021
`c10::str()` is often used with variadic macros. It can be more efficient to get a C string out if you put a C string in, like if you are able to defer std::string creation to an outlined function or even never do it at all. Meanwhile, there is an implicit conversion from const char* to std::string, so users who expected a std::string will still make one. Differential Revision: [D26419663](https://our.internmc.facebook.com/intern/diff/D26419663/) [ghstack-poisoned]
`c10::str()` is often used with variadic macros. It can be more efficient to get a C string out if you put a C string in, like if you are able to defer std::string creation to an outlined function or even never do it at all. Meanwhile, there is an implicit conversion from const char* to std::string, so users who expected a std::string will still make one. Differential Revision: [D26419663](https://our.internmc.facebook.com/intern/diff/D26419663/) [ghstack-poisoned]
`c10::str()` is often used with variadic macros. It can be more efficient to get a C string out if you put a C string in, like if you are able to defer std::string creation to an outlined function or even never do it at all. Meanwhile, there is an implicit conversion from const char* to std::string, so users who expected a std::string will still make one. Differential Revision: [D26419663](https://our.internmc.facebook.com/intern/diff/D26419663/) [ghstack-poisoned]
|
This pull request has been merged in d675593. |
iramazanli
pushed a commit
to iramazanli/pytorch
that referenced
this pull request
Feb 23, 2021
Summary: Pull Request resolved: pytorch#52222 `c10::str()` is often used with variadic macros. It can be more efficient to get a C string out if you put a C string in, like if you are able to defer std::string creation to an outlined function or even never do it at all. Meanwhile, there is an implicit conversion from const char* to std::string, so users who expected a std::string will still make one. ghstack-source-id: 121877052 (Note: this ignores all push blocking failures!) Test Plan: CI Reviewed By: bhosmer Differential Revision: D26419663 fbshipit-source-id: 400bef71e6a0004b5914f5f511ea0e04e0d7599b
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
Summary: Pull Request resolved: pytorch#52222 `c10::str()` is often used with variadic macros. It can be more efficient to get a C string out if you put a C string in, like if you are able to defer std::string creation to an outlined function or even never do it at all. Meanwhile, there is an implicit conversion from const char* to std::string, so users who expected a std::string will still make one. ghstack-source-id: 121877052 (Note: this ignores all push blocking failures!) Test Plan: CI Reviewed By: bhosmer Differential Revision: D26419663 fbshipit-source-id: 400bef71e6a0004b5914f5f511ea0e04e0d7599b
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#52222 `c10::str()` is often used with variadic macros. It can be more efficient to get a C string out if you put a C string in, like if you are able to defer std::string creation to an outlined function or even never do it at all. Meanwhile, there is an implicit conversion from const char* to std::string, so users who expected a std::string will still make one. ghstack-source-id: 121877052 (Note: this ignores all push blocking failures!) Test Plan: CI Reviewed By: bhosmer Differential Revision: D26419663 fbshipit-source-id: 400bef71e6a0004b5914f5f511ea0e04e0d7599b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
c10::str()is often used with variadic macros. It can be more efficient to get a C string out if you put a C string in, like if you are able to defer std::string creation to an outlined function or even never do it at all. Meanwhile, there is an implicit conversion from const char* to std::string, so users who expected a std::string will still make one.Differential Revision: D26419663