Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports fix for division documentation that removes "true" rounding mode #52242

Merged
merged 1 commit into from Feb 14, 2021

Conversation

mruberry
Copy link
Collaborator

Fixes a design issue identified late in 1.8 development by @gchanan that a "rounding mode" named "true" which performs no rounding is confusing.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 12, 2021

💊 CI failures summary and remediations

As of commit e356aa3 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #52242 (e356aa3) into release/1.8 (c307a3f) will increase coverage by 0.33%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/1.8   #52242      +/-   ##
===============================================
+ Coverage        80.48%   80.82%   +0.33%     
===============================================
  Files             1948     1948              
  Lines           213183   213183              
===============================================
+ Hits            171588   172296     +708     
+ Misses           41595    40887     -708     

@malfet malfet merged commit cd63c37 into release/1.8 Feb 14, 2021
@mruberry mruberry deleted the rounding_mode_doc_fixes branch May 2, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants