Use int8_t instead of char in [load|store]_scalar`
#52616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 7a074ca (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
Summary: Since `char` is not guaranteed to be signed on all platforms (it is unsigned on ARM) Fixes pytorch#52146 Pull Request resolved: pytorch#52616 Test Plan: Run ` python3 -c "import torch;a=torch.tensor([-1], dtype=torch.int8);print(a.tolist())"` on arm-linux system Reviewed By: walterddr Differential Revision: D26586678 Pulled By: malfet fbshipit-source-id: 91972189b54f86add516ffb96d579acb0bc13311
malfet
added a commit
to malfet/pytorch
that referenced
this pull request
Mar 15, 2021
Summary: Since `char` is not guaranteed to be signed on all platforms (it is unsigned on ARM) Fixes pytorch#52146 Pull Request resolved: pytorch#52616 Test Plan: Run ` python3 -c "import torch;a=torch.tensor([-1], dtype=torch.int8);print(a.tolist())"` on arm-linux system Reviewed By: walterddr Differential Revision: D26586678 Pulled By: malfet fbshipit-source-id: 91972189b54f86add516ffb96d579acb0bc13311
This was referenced Mar 15, 2021
malfet
added a commit
that referenced
this pull request
Mar 16, 2021
Summary: Since `char` is not guaranteed to be signed on all platforms (it is unsigned on ARM) Fixes #52146 Pull Request resolved: #52616 Test Plan: Run ` python3 -c "import torch;a=torch.tensor([-1], dtype=torch.int8);print(a.tolist())"` on arm-linux system Reviewed By: walterddr Differential Revision: D26586678 Pulled By: malfet fbshipit-source-id: 91972189b54f86add516ffb96d579acb0bc13311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
charis not guaranteed to be signed on all platforms (it is unsigned on ARM)Fixes #52146