Add 64bit indexing support for softmax #52713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 48f0eba (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
|
cc: @ptrblck |
zasdfgbnm
added
the
module: cuda
|
@ngimel I have fixed the bug you catch, and added a test. The test passes on my 3090. |
zasdfgbnm
commented
Feb 24, 2021
| @@ -11975,6 +11975,25 @@ def test_softmax_results(self, device, dtype): | |||
| self.assertEqual(grad_input, ref_grad_input) | |||
| self.assertEqual(input.grad, ref_input.grad) | |||
|
|
|||
| @onlyCUDA | |||
| @dtypesIfCUDA(torch.float, torch.half) | |||
| @largeTensorTest("20GB") | |||
There was a problem hiding this comment.
On my 3090, half takes ~18GB mem, and float takes ~19.8GB
There was a problem hiding this comment.
Will these tests run in your CI?
There was a problem hiding this comment.
Our CI has A100 and 3090, so yes!
ngimel
approved these changes
Feb 24, 2021
| @@ -11975,6 +11975,25 @@ def test_softmax_results(self, device, dtype): | |||
| self.assertEqual(grad_input, ref_grad_input) | |||
| self.assertEqual(input.grad, ref_input.grad) | |||
|
|
|||
| @onlyCUDA | |||
| @dtypesIfCUDA(torch.float, torch.half) | |||
| @largeTensorTest("20GB") | |||
There was a problem hiding this comment.
Will these tests run in your CI?
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
Summary: fixes pytorch#52715 pytorch#52716 split across batch dimension Pull Request resolved: pytorch#52713 Reviewed By: ailzhang Differential Revision: D26640033 Pulled By: ngimel fbshipit-source-id: f169cb0d6abc1cfbddf658d9775759a7d56f5c12
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: fixes pytorch#52715 pytorch#52716 split across batch dimension Pull Request resolved: pytorch#52713 Reviewed By: ailzhang Differential Revision: D26640033 Pulled By: ngimel fbshipit-source-id: f169cb0d6abc1cfbddf658d9775759a7d56f5c12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #52715 #52716
split across batch dimension