Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[numpy] torch.i0: promote integer inputs to float #52735

Closed
wants to merge 4 commits into from
Closed

[numpy] torch.i0: promote integer inputs to float #52735

wants to merge 4 commits into from

Conversation

kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Feb 24, 2021 •
edited
Loading

Reference : #42515

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 24, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 7eb9b74 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

kshitij12345
kshitij12345 commented May 13, 2021
View reviewed changes
torch/testing/_internal/common_methods_invocations.py
@@ -1972,6 +1972,24 @@ def wrapped_fn(x):
return wrapped_fn


def np_unary_ufunc_integer_promotion_wrapper_with_astype(fn):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from #56352

@kshitij12345 kshitij12345 marked this pull request as ready for review May 13, 2021 13:49
@ejguan ejguan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #52735 (7eb9b74) into master (6997e7b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #52735      +/-   ##
==========================================
- Coverage   76.80%   76.80%   -0.01%     
==========================================
  Files        1986     1986              
  Lines      198237   198247      +10     
==========================================
+ Hits       152255   152259       +4     
- Misses      45982    45988       +6

mruberry
mruberry approved these changes May 23, 2021
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I'm still not in love with that astype function but we don't need to sort out anything better at the moment. It's good enough.

Nice work, @kshitij12345

@facebook-github-bot
Copy link
Contributor

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@kshitij12345
Copy link
Collaborator Author

I'm still not in love with that astype function but we don't need to sort out anything better at the moment. It's good enough.

I know :). Will clean it up in #56352 (assuming this gets merged first)

Thanks :)

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in 948df6c.

deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
@kshitij12345 @deniskokarev
[numpy] torch.i0: promote integer inputs to float (pytorch#52735)
5d92833 
Summary:
Reference : pytorch#42515

Pull Request resolved: pytorch#52735

Reviewed By: zou3519

Differential Revision: D28630505

Pulled By: mruberry

fbshipit-source-id: e81a35dfc1a322daf0c44718901470fac677bc94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry mruberry approved these changes

Assignees
No one assigned
Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kshitij12345 @facebook-github-bot @mruberry @pytorchbot @ejguan