Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyPer] More at::empty -> at::detail::empty_cpu #53333

Closed
wants to merge 1 commit into from

Conversation

hlu1
Copy link
Contributor

@hlu1 hlu1 commented Mar 5, 2021

Summary:

  • Add more variants to create_empty_from to take more args, like dtype/layout/device.
  • Clean up stray at::empty uses, mostly in the out variants.

Reviewed By: ajyu

Differential Revision: D26799900

Summary:
- Add more variants to `create_empty_from` to take more args, like dtype/layout/device.
- Clean up stray at::empty uses, mostly in the out variants.

Reviewed By: ajyu

Differential Revision: D26799900

fbshipit-source-id: bee8277a1158e04f3ad3713ecc046395cceda460
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 5, 2021

💊 CI failures summary and remediations

As of commit 49a699e (more details on the Dr. CI page):


  • 1/2 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)
  • 1/2 broken upstream at merge base 795ed5c on Mar 04 from 7:10pm to 10:11pm

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue fb-exported labels Mar 5, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D26799900

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 63e0e88.

aocsa pushed a commit to Quansight/pytorch that referenced this pull request Mar 15, 2021
Summary:
Pull Request resolved: pytorch#53333

- Add more variants to `create_empty_from` to take more args, like dtype/layout/device.
- Clean up stray at::empty uses, mostly in the out variants.

Reviewed By: ajyu

Differential Revision: D26799900

fbshipit-source-id: 6676d8043fead63208913ef3a28cabbae76e46bb
xsacha pushed a commit to xsacha/pytorch that referenced this pull request Mar 31, 2021
Summary:
Pull Request resolved: pytorch#53333

- Add more variants to `create_empty_from` to take more args, like dtype/layout/device.
- Clean up stray at::empty uses, mostly in the out variants.

Reviewed By: ajyu

Differential Revision: D26799900

fbshipit-source-id: 6676d8043fead63208913ef3a28cabbae76e46bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants