Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot #53453

heitorschueroff · 2021-03-06T14:50:36Z

Stack from ghstack:

Replace torch.chain_matmul calls to torch.linalg.multi_dot #55064 Replace torch.chain_matmul calls to torch.linalg.multi_dot
Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot #53453 Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot
[Relanding] Implemented torch.linalg.multi_dot #52859 [Relanding] Implemented torch.linalg.multi_dot

Differential Revision: D27406282

[ghstack-poisoned]

ghstack-source-id: c8fe7ef8fae80e9498c7b9b3eaef63851e57bb9b Pull Request resolved: #53453

facebook-github-bot · 2021-03-06T14:50:54Z

💊 CI failures summary and remediations

As of commit 3684278 (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-scanned failure(s)

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

…i_dot" [ghstack-poisoned]

ghstack-source-id: c8fe7ef8fae80e9498c7b9b3eaef63851e57bb9b Pull Request resolved: #53453

…i_dot" [ghstack-poisoned]

ghstack-source-id: a951a581cb5e351665bddb26850b3d844edea304 Pull Request resolved: #53453

…i_dot" [ghstack-poisoned]

ghstack-source-id: 87b18c7ea86acd38e6fea0bc1435aba3c10c9122 Pull Request resolved: #53453

…i_dot" [ghstack-poisoned]

ghstack-source-id: 3838e611caf4627a42fd0379bdc210a3a6175329 Pull Request resolved: #53453

aten/src/ATen/autocast_mode.cpp

test/test_autograd.py

test/test_linalg.py

mruberry · 2021-03-12T20:35:47Z

torch/testing/_internal/common_methods_invocations.py

-        [(2, S), (S, 2), (2, S)],
+    # Each test case consists of the sizes in the chain of multiplications
+    # e.g. [2, S, 2, S] generates matrices (2, S) @ (S, 2) @ (2, S)
+    test_cases = [


How much does this increase test time by? Is the net test time decreased or increased with the chain_matmul() test removal?

torch/functional.py

…i_dot" [ghstack-poisoned]

ghstack-source-id: ec6db31ce3af029eeb2546e24e5a9721c411c487 Pull Request resolved: #53453

…i_dot" [ghstack-poisoned]

torch/functional.py

mruberry

Cool! Let's get this merged. We can worry about docs refinements in our docs review before the 1.9 release.

…i_dot" [ghstack-poisoned]

test/test_linalg.py

Co-authored-by: anjali411 <chourdiaanjali123@gmail.com>

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

ghstack-source-id: f97e541437bac8640db5dfac9e1e6422bede8008 Pull Request resolved: #53453

ezyang · 2021-03-30T02:36:28Z

ACKing native_functions.yaml changes

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

ghstack-source-id: 5f1c0927fccf073541730751d9f8308caa7b4b90 Pull Request resolved: #53453

…ting on "Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

ghstack-source-id: ef79a827770dc501cefc7a7822b07237ae627a13 Pull Request resolved: #53453

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

ghstack-source-id: d031d0af2573dfa330d73d9e91481692a92ae493 Pull Request resolved: #53453

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

ghstack-source-id: ea6666b6d52128d9116774ad6ba4b62bb586982b Pull Request resolved: #53453

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

ghstack-source-id: b5a98a2ece6e11b3978c71f0ca992b0a3763d826 Pull Request resolved: #53453

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

facebook-github-bot · 2021-04-01T11:51:12Z

@heitorschueroff merged this pull request in d98072b.

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

194e9ae

[ghstack-poisoned]

This was referenced Mar 6, 2021

Fix gradcheck failing for OpInfo with TensorList inputs #53418

Closed

[Relanding] Implemented torch.linalg.multi_dot #52859

Closed

heitorschueroff added a commit that referenced this pull request Mar 6, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

86f3351

ghstack-source-id: c8fe7ef8fae80e9498c7b9b3eaef63851e57bb9b Pull Request resolved: #53453

facebook-github-bot added the cla signed label Mar 6, 2021

heitorschueroff requested a review from mruberry March 6, 2021 14:54

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

025f1f2

…i_dot" [ghstack-poisoned]

heitorschueroff added a commit that referenced this pull request Mar 6, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

3978466

ghstack-source-id: c8fe7ef8fae80e9498c7b9b3eaef63851e57bb9b Pull Request resolved: #53453

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

0d890d4

…i_dot" [ghstack-poisoned]

heitorschueroff added a commit that referenced this pull request Mar 9, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

fc4bee6

ghstack-source-id: a951a581cb5e351665bddb26850b3d844edea304 Pull Request resolved: #53453

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

d8f0708

…i_dot" [ghstack-poisoned]

heitorschueroff added a commit that referenced this pull request Mar 11, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

8f9dc98

ghstack-source-id: 87b18c7ea86acd38e6fea0bc1435aba3c10c9122 Pull Request resolved: #53453

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

8b0889f

…i_dot" [ghstack-poisoned]

heitorschueroff added a commit that referenced this pull request Mar 12, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

26b40cd

ghstack-source-id: 3838e611caf4627a42fd0379bdc210a3a6175329 Pull Request resolved: #53453

mruberry reviewed Mar 12, 2021

View reviewed changes

aten/src/ATen/autocast_mode.cpp Outdated Show resolved Hide resolved

mruberry reviewed Mar 12, 2021

View reviewed changes

test/test_autograd.py Show resolved Hide resolved

mruberry reviewed Mar 12, 2021

View reviewed changes

test/test_linalg.py Show resolved Hide resolved

mruberry reviewed Mar 12, 2021

View reviewed changes

torch/functional.py Outdated Show resolved Hide resolved

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

146508f

…i_dot" [ghstack-poisoned]

heitorschueroff added a commit that referenced this pull request Mar 17, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

3fa982b

ghstack-source-id: ec6db31ce3af029eeb2546e24e5a9721c411c487 Pull Request resolved: #53453

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

6dd047a

…i_dot" [ghstack-poisoned]

heitorschueroff requested a review from mruberry March 29, 2021 16:13

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

67f31af

…i_dot" [ghstack-poisoned]

heitorschueroff requested a review from ezyang as a code owner March 29, 2021 16:25

mruberry reviewed Mar 29, 2021

View reviewed changes

torch/functional.py Show resolved Hide resolved

mruberry approved these changes Mar 29, 2021

View reviewed changes

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

e4164d5

…i_dot" [ghstack-poisoned]

anjali411 reviewed Mar 29, 2021

View reviewed changes

test/test_linalg.py Show resolved Hide resolved

heitorschueroff and others added 2 commits March 29, 2021 15:52

Update test/test_linalg.py

8abb119

Co-authored-by: anjali411 <chourdiaanjali123@gmail.com>

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

c71d440

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

f6381eb

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

heitorschueroff added a commit that referenced this pull request Mar 29, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

8ab8a1c

ghstack-source-id: f97e541437bac8640db5dfac9e1e6422bede8008 Pull Request resolved: #53453

ezyang closed this Mar 30, 2021

ezyang reopened this Mar 30, 2021

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

c0d74fd

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

heitorschueroff added a commit that referenced this pull request Mar 30, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

e565b03

ghstack-source-id: 5f1c0927fccf073541730751d9f8308caa7b4b90 Pull Request resolved: #53453

added wrapper function to pack inputs to multi_dot in distributed tes…

fc36b1f

…ting on "Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

heitorschueroff added a commit that referenced this pull request Mar 30, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

6638e02

ghstack-source-id: ef79a827770dc501cefc7a7822b07237ae627a13 Pull Request resolved: #53453

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

5b49fee

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

heitorschueroff added a commit that referenced this pull request Mar 30, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

8ea0f70

ghstack-source-id: d031d0af2573dfa330d73d9e91481692a92ae493 Pull Request resolved: #53453

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

88c4944

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

heitorschueroff added a commit that referenced this pull request Mar 30, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

e56150a

ghstack-source-id: ea6666b6d52128d9116774ad6ba4b62bb586982b Pull Request resolved: #53453

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

14670b4

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

heitorschueroff added a commit that referenced this pull request Mar 31, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot

9187eba

ghstack-source-id: b5a98a2ece6e11b3978c71f0ca992b0a3763d826 Pull Request resolved: #53453

Update on "Deprecate torch.chain_matmul in favor of torch.linalg.mult…

3684278

…i_dot" Differential Revision: [D27406282](https://our.internmc.facebook.com/intern/diff/D27406282) [ghstack-poisoned]

heitorschueroff mentioned this pull request Mar 31, 2021

Replace torch.chain_matmul calls to torch.linalg.multi_dot #55064

Closed

facebook-github-bot closed this in d98072b Apr 1, 2021

facebook-github-bot added the Merged label Apr 1, 2021

facebook-github-bot deleted the gh/heitorschueroff/55/head branch April 4, 2021 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot #53453

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot #53453

heitorschueroff commented Mar 6, 2021 •

edited

facebook-github-bot commented Mar 6, 2021 •

edited

mruberry Mar 12, 2021 •

edited

mruberry left a comment

ezyang commented Mar 30, 2021

facebook-github-bot commented Apr 1, 2021

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot #53453

Deprecate torch.chain_matmul in favor of torch.linalg.multi_dot #53453

Conversation

heitorschueroff commented Mar 6, 2021 • edited

facebook-github-bot commented Mar 6, 2021 • edited

💊 CI failures summary and remediations

mruberry Mar 12, 2021 • edited

Choose a reason for hiding this comment

mruberry left a comment

Choose a reason for hiding this comment

ezyang commented Mar 30, 2021

facebook-github-bot commented Apr 1, 2021

heitorschueroff commented Mar 6, 2021 •

edited

facebook-github-bot commented Mar 6, 2021 •

edited

mruberry Mar 12, 2021 •

edited