Fix gradcheck failing for OpInfo with TensorList inputs #53418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 770181a (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This PR adds a workaround to OpInfo tests for ops that take TensoList inputs which were failing gradcheck (see #51996). It also updates the *stack ops to pass in a list of Tensors as input to SampleInput to demonstrate that the tests now pass without the need for defining a lambda in op. [ghstack-poisoned]
This PR adds a workaround to OpInfo tests for ops that take TensoList inputs which were failing gradcheck (see #51996). It also updates the *stack ops to pass in a list of Tensors as input to SampleInput to demonstrate that the tests now pass without the need for defining a lambda in op. Differential Revision: [D26860788](https://our.internmc.facebook.com/intern/diff/D26860788) [ghstack-poisoned]
This PR adds a workaround to OpInfo tests for ops that take TensoList inputs which were failing gradcheck (see #51996). It also updates the *stack ops to pass in a list of Tensors as input to SampleInput to demonstrate that the tests now pass without the need for defining a lambda in op. Differential Revision: [D26860788](https://our.internmc.facebook.com/intern/diff/D26860788) [ghstack-poisoned]
This PR adds a workaround to OpInfo tests for ops that take TensoList inputs which were failing gradcheck (see #51996). It also updates the *stack ops to pass in a list of Tensors as input to SampleInput to demonstrate that the tests now pass without the need for defining a lambda in op. Differential Revision: [D26860788](https://our.internmc.facebook.com/intern/diff/D26860788) [ghstack-poisoned]
This PR adds a workaround to OpInfo tests for ops that take TensoList inputs which were failing gradcheck (see #51996). It also updates the *stack ops to pass in a list of Tensors as input to SampleInput to demonstrate that the tests now pass without the need for defining a lambda in op. Differential Revision: [D26860788](https://our.internmc.facebook.com/intern/diff/D26860788) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/heitorschueroff/54/base #53418 +/- ##
==============================================================
+ Coverage 77.36% 77.43% +0.07%
==============================================================
Files 1879 1869 -10
Lines 183270 182394 -876
==============================================================
- Hits 141782 141242 -540
+ Misses 41488 41152 -336 |
This PR adds a workaround to OpInfo tests for ops that take TensoList inputs which were failing gradcheck (see #51996). It also updates the *stack ops to pass in a list of Tensors as input to SampleInput to demonstrate that the tests now pass without the need for defining a lambda in op. Differential Revision: [D26860788](https://our.internmc.facebook.com/intern/diff/D26860788) [ghstack-poisoned]
mruberry
reviewed
Mar 12, 2021
mruberry
reviewed
Mar 12, 2021
mruberry
reviewed
Mar 12, 2021
mruberry
reviewed
Mar 12, 2021
|
I really like this change and the design looks good. I've asked @IvanYashchuk to weigh in on removing the two OpInfo classes for linalg operations. Although this PR can replace them in the current build, I think he may have plans for them. Looks like the test failures are just mypy issues. |
|
This PR resolves #50837. |
This PR adds a workaround to OpInfo tests for ops that take TensoList inputs which were failing gradcheck (see #51996). It also updates the *stack ops to pass in a list of Tensors as input to SampleInput to demonstrate that the tests now pass without the need for defining a lambda in op. Differential Revision: [D26860788](https://our.internmc.facebook.com/intern/diff/D26860788) [ghstack-poisoned]
This PR adds a workaround to OpInfo tests for ops that take TensoList inputs which were failing gradcheck (see #51996). It also updates the *stack ops to pass in a list of Tensors as input to SampleInput to demonstrate that the tests now pass without the need for defining a lambda in op. Differential Revision: [D26860788](https://our.internmc.facebook.com/intern/diff/D26860788) [ghstack-poisoned]
heitorschueroff
commented
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR adds a workaround to OpInfo tests for ops that take TensoList inputs which were failing gradcheck (see #51996). It also updates the *stack ops to pass in a list of Tensors as input to SampleInput to demonstrate that the tests now pass without the need for defining a lambda in op.
Differential Revision: D26860788